support binding annotations for guice injection.#473
Closed
portlek wants to merge 9 commits intoIncendo:1.9.0-devfrom
forkstuffs:feat/binding-annotations
Closed
support binding annotations for guice injection.#473portlek wants to merge 9 commits intoIncendo:1.9.0-devfrom forkstuffs:feat/binding-annotations
portlek wants to merge 9 commits intoIncendo:1.9.0-devfrom
forkstuffs:feat/binding-annotations
Conversation
Citymonstret
approved these changes
Nov 1, 2023
Contributor
Author
|
I rebase the PR to 1.9.0-dev again. it's ready to merge. |
Contributor
Author
|
@jpenilla could you review the PR, please? |
Citymonstret
added a commit
that referenced
this pull request
Dec 20, 2023
- Use an immutable interface rather than a triplet as the input to injection services - Allow injection using `TypeToken` This also pulls in the changes from #473. Co-authored-by: Hasan Demirtaş <utsukushihito@outlook.com>
Citymonstret
added a commit
that referenced
this pull request
Dec 20, 2023
- Use an immutable interface rather than a triplet as the input to injection services - Allow injection using `TypeToken` This also pulls in the changes from #473. Co-authored-by: Hasan Demirtaş <utsukushihito@outlook.com>
Citymonstret
added a commit
that referenced
this pull request
Dec 21, 2023
- Use an immutable interface rather than a triplet as the input to injection services - Allow injection using `TypeToken` This also pulls in the changes from #473. Co-authored-by: Hasan Demirtaş <utsukushihito@outlook.com>
Member
|
This has been pulled into 2.0.0-dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.