feat(bottom-nav): indigo theme support for bottom navigation#7651
Merged
simeonoff merged 3 commits intosimeonoff/indigo-themefrom Jun 29, 2020
Merged
feat(bottom-nav): indigo theme support for bottom navigation#7651simeonoff merged 3 commits intosimeonoff/indigo-themefrom
simeonoff merged 3 commits intosimeonoff/indigo-themefrom
Conversation
simeonoff
requested changes
Jun 23, 2020
Collaborator
simeonoff
left a comment
There was a problem hiding this comment.
The following colors do not match the design:
- Background color in dark mode
- Idle text/icon color in dark mode
simeonoff
requested changes
Jun 24, 2020
projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_bottom-nav.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_bottom-nav.scss
Outdated
Show resolved
Hide resolved
simeonoff
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)