Skip to content

Test .py files from examples as part of Integration tests #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sufikaur merged 3 commits into from
Oct 2, 2025
Merged

Test .py files from examples as part of Integration tests #1679

sufikaur merged 3 commits into from
Oct 2, 2025

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Oct 2, 2025

Fixes NA

Summary/Motivation:

We recently found out that the integration tests only running the notebooks can actually cause us to miss some regressions between idaes-pse and examples (see PR #1677 ). This turns on testing both notebooks and test_*.py files in the examples repo as part of the integration tests.

Changes proposed in this PR:

  • Introduce new environment variables to control both notebook and .py files into the driver
  • Modify the action appropriately

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Oct 2, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (0ca2acb) to head (8182218).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
- Coverage   77.07%   77.06%   -0.01%     
==========================================
  Files         395      395              
  Lines       62759    62759              
  Branches    10234    10234              
==========================================
- Hits        48369    48366       -3     
- Misses      11978    11982       +4     
+ Partials     2412     2411       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 2, 2025
ksbeattie
ksbeattie approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sufikaur sufikaur merged commit d495c8d into IDAES:main Oct 2, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@blnicho blnicho blnicho approved these changes

@sufikaur sufikaur sufikaur approved these changes

@agarciadiego agarciadiego Awaiting requested review from agarciadiego

@dallan-keylogic dallan-keylogic Awaiting requested review from dallan-keylogic

Assignees

No one assigned

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrmundt @ksbeattie @blnicho @sufikaur @idaes-build