Fix initialization of FpcTP with one phase #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blnicho
approved these changes
Oct 2, 2025
Member
blnicho
left a comment
There was a problem hiding this comment.
@dallan-keylogic thanks for helping us debug the issue and for fixing it!
mrmundt
approved these changes
Oct 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
- Coverage 77.08% 77.06% -0.02%
==========================================
Files 395 395
Lines 62761 62759 -2
Branches 10233 10234 +1
==========================================
- Hits 48377 48366 -11
- Misses 11977 11982 +5
- Partials 2407 2411 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
@blnicho and @mrmundt discovered a test failure in examples that was not picked up by the CI because we only run the notebooks in examples in the CI, not any tests in .py files. This PR fixes that issue, and I've verified that it works on my local machine.
When
FpcTPstate variables are used without any VLE present,fix_initialization_statesattempts to deactivateequilibirum_constraint, which results in anAttributeError. This PR fixes that problem and adds a test to make sure the problem stays fixed.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: