Custom JSON encoder and decoder block properties#23
Custom JSON encoder and decoder block properties#23tib wants to merge 2 commits intoKitura:masterfrom tib:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 71.96% 69.85% -2.12%
==========================================
Files 2 2
Lines 132 136 +4
==========================================
Hits 95 95
- Misses 37 41 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGTM, @ianpartridge would this be a breaking change? Actually it isn't I believe
| expectation1.fulfill() | ||
| } | ||
| waitForExpectations(timeout: 3.0, handler: nil) | ||
| } |
There was a problem hiding this comment.
@EnriqueL8 this is not a breaking change, it's an minor additional option for configuring custom JSON encoders and decoders.
|
@tib Thank you for the effort that you put in to both this and the corresponding Kitura PR. The Kitura one was further developed into Kitura/Kitura#1221, and likewise @Andrew-Lees11 has developed the corresponding KituraKit change in #38 . I'm closing this PR in favour of #38, which provides equivalent functionality but generalised for any media type. |
In order to support the new custom JSONEncoder in Kitura it is required to introduce new customizable JSON encoder and decoder properties in KituraKit as well. See this PR.