Feat: Add custom Encoder and Decoder#38
Merged
Andrew-Lees11 merged 4 commits intomasterfrom Apr 8, 2019
Merged
Conversation
5 tasks
e64c7db to
e809149
Compare
djones6
approved these changes
Apr 4, 2019
Contributor
djones6
left a comment
There was a problem hiding this comment.
This looks great! Small comment on docs, but otherwise I think this looks good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #37 Custom Encoders and decoders.
It adds a variable encoder and decoder to the KituraKit client. These coders are then used to encode/decode the request as well as set the Content-Type and Accept header.
This maps into the Kitura API for custom encoder and decoder so that you can use a different serialization for sending objects accross codable routes.