feat(Partner Center Sell): extending IAM and Deployment objects with new parameters#449
Merged
pyrooka merged 3 commits intoJun 4, 2026
Conversation
…to deployments, default values for cbr, also new parameter for them called event_publishing on the IAM service object Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
Contributor
Author
|
Example tests |
Contributor
Author
|
Integration tests: |
Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
pyrooka
reviewed
Jun 3, 2026
pyrooka
left a comment
Member
There was a problem hiding this comment.
Overall the PR looks good, but left a question to talk about before merging.
| } | ||
|
|
||
| // DefaultServiceURL is the default URL to make service requests to. | ||
| const DefaultServiceURL = "https://product-lifecycle.cloud.ibm.com/openapi/v1" |
Member
There was a problem hiding this comment.
Merely a question, but is this new default service URL correct? Using localhost doesn't seem right to me in this context, but please correct me if I'm wrong.
|
|
3dd2d63 to
eaae460
Compare
Signed-off-by: Attila Ambrus <aattila0@proton.me>
eaae460 to
89c08b8
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 4, 2026
# [0.99.0](v0.98.0...v0.99.0) (2026-06-04) ### Features * **Partner Center Sell:** extending IAM and Deployment objects with new parameters ([#449](#449)) ([be5979c](be5979c))
|
🎉 This PR is included in version 0.99.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adding new parameter metadata.other. location_proxied_by to deployment objects
Adding supportedNetwork.operations.defaults option for IAM CBR
Adding eventPublishing option for CBR
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information