Skip to content

feat(IAM Identity): add PowerVS compute resource type support#448

Merged
pyrooka merged 3 commits into
IBM:mainfrom
briangleeson:fixIamIdentityPreference
May 27, 2026
Merged

feat(IAM Identity): add PowerVS compute resource type support#448
pyrooka merged 3 commits into
IBM:mainfrom
briangleeson:fixIamIdentityPreference

Conversation

@briangleeson

@briangleeson briangleeson commented May 22, 2026

Copy link
Copy Markdown
Member

PR summary

This PR replaces a previous PR (as Poorani has left IBM): #441

  • Add support for PowerVS compute resource type
  • Fix issue with value_string in Identity Preference handling

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@briangleeson briangleeson changed the title Fix iam identity preference Add PowerVS compute resource type support May 22, 2026
@briangleeson briangleeson mentioned this pull request May 22, 2026
Closed
5 tasks
@briangleeson briangleeson force-pushed the fixIamIdentityPreference branch from 6c89630 to 8b33428 Compare May 22, 2026 14:31
@CLAassistant

CLAassistant commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@briangleeson briangleeson mentioned this pull request May 22, 2026
Open
4 tasks
@briangleeson briangleeson force-pushed the fixIamIdentityPreference branch 2 times, most recently from 1d30567 to 6a9e645 Compare May 22, 2026 15:06
@pyrooka pyrooka self-requested a review May 22, 2026 16:21
@briangleeson

briangleeson commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

IAM Identity test results:

$ go test -timeout 20m
Running Suite: IamIdentityV1 Suite
==================================
Random Seed: 1779794433
Will run 495 of 495 specs

Ran 495 of 495 Specs in 18.833 seconds
SUCCESS! -- 495 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   21.082s

$ go test -tags=examples -timeout 1200s
Running Suite: IamIdentityV1 Suite
==================================
Random Seed: 1779793616
Will run 583 of 583 specs

Ran 583 of 583 Specs in 744.636 seconds
SUCCESS! -- 583 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   746.795s

$ go test -tags=integration -timeout 1200s
Running Suite: IamIdentityV1 Suite
==================================
Random Seed: 1779709856
Will run 600 of 600 specs

Ran 600 of 600 Specs in 801.000 seconds
SUCCESS! -- 600 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   803.115s

@briangleeson briangleeson force-pushed the fixIamIdentityPreference branch 3 times, most recently from 0a764ad to cd1723e Compare May 26, 2026 09:37
pyrooka
pyrooka requested changes May 26, 2026
View reviewed changes

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the final review I'd like to ask two things:

  1. Format the code. You'll like want to run go fmt ./iamidentityv1
  2. Run the examples test and add the result to the PR - just like you did with the integration tests. We need to make sure the examples are correct and work fine.

@briangleeson briangleeson force-pushed the fixIamIdentityPreference branch from cd1723e to 710cd84 Compare May 26, 2026 11:25
@briangleeson
feat(iam-identity): add support for PowerVS compute resource type
64b81f3 
Signed-off-by: BRIAN GLEESON <Brian.Gleeson@ie.ibm.com>
@briangleeson
fix(iam-identity): make value_string optional for Identity preferences
4c0e350 
Signed-off-by: BRIAN GLEESON <Brian.Gleeson@ie.ibm.com>
@briangleeson briangleeson force-pushed the fixIamIdentityPreference branch from 710cd84 to 4c0e350 Compare May 26, 2026 11:26
@briangleeson

briangleeson commented May 26, 2026

Copy link
Copy Markdown
Member Author

@pyrooka

  • Code formatted (and updated our runbook to include that step)
  • Rebased the PR
  • examples test results:
$ go test -tags=examples -timeout 1200s
Running Suite: IamIdentityV1 Suite
==================================
Random Seed: 1779793616
Will run 583 of 583 specs

Ran 583 of 583 Specs in 744.636 seconds
SUCCESS! -- 583 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   746.795s

pyrooka
pyrooka approved these changes May 26, 2026
View reviewed changes

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments @briangleeson , the PR looks good now!

@pyrooka pyrooka changed the title Add PowerVS compute resource type support feat(IAM Identity): add PowerVS compute resource type support May 26, 2026
@pyrooka pyrooka merged commit a87c38e into IBM:main May 27, 2026
7 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request May 27, 2026
@semantic-release-bot
chore(release): 0.98.0 release notes [skip ci]
cbd25a3 
# [0.98.0](v0.97.5...v0.98.0) (2026-05-27)

### Features

* **IAM Identity:** add PowerVS compute resource type support ([#448](#448)) ([a87c38e](a87c38e))
@ibm-devx-sdk

ibm-devx-sdk commented May 27, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 0.98.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced May 28, 2026
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@briangleeson @CLAassistant @ibm-devx-sdk @pyrooka