Skip to content

fix(Metrics Router): add in-mum region#446

Merged
pyrooka merged 2 commits into
IBM:mainfrom
PhaniDivi-613:add-mr-mum
May 26, 2026
Merged

fix(Metrics Router): add in-mum region#446
pyrooka merged 2 commits into
IBM:mainfrom
PhaniDivi-613:add-mr-mum

Conversation

@PhaniDivi-613

@PhaniDivi-613 PhaniDivi-613 commented May 19, 2026

Copy link
Copy Markdown
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant

CLAassistant commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pyrooka
❌ Phaneendra Divi

Phaneendra Divi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PhaniDivi-613

PhaniDivi-613 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author
image

@PhaniDivi-613 PhaniDivi-613 changed the title Add in-mum MR region fix(Metrics Router): Add in-mum MR region May 21, 2026
pyrooka
pyrooka approved these changes May 21, 2026
View reviewed changes

@pyrooka pyrooka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually require evidence of clean test runs for both integration tests and examples (unit tests are covered in the CI build), but I make an exception this time since the changes are pretty straightforward and should not affect the aformentioned tests.

@pyrooka

pyrooka commented May 21, 2026

Copy link
Copy Markdown
Member

@PhaniDivi-613 Again, I already approved this PR and won't take it back, but I kindly ask you to follow our guidelines next time! I'm saying this because

  1. You (or someone else?) manually set the DCO check to pass, even though your single commit on the branch is not signed-off. We have a complete section about this in the docs
  2. You've used your internal github user - I assume - so the author of the commit and the GitHub user who opened the PR cannot be linked together. That's why you cannot make the CLA check to pass. If you work on open source projects, please use your public GH profile.

Since you've already contributed to this project I overlook these, but next time please pay attention! Thank you!

@pyrooka pyrooka changed the title fix(Metrics Router): Add in-mum MR region fix(Metrics Router): add in-mum region May 21, 2026
@pyrooka

pyrooka commented May 21, 2026

Copy link
Copy Markdown
Member

@PhaniDivi-613 Also, are you planning to open similar PRs in other language repos, or this is Go only so I can merge the PR?

@PhaniDivi-613

PhaniDivi-613 commented May 24, 2026

Copy link
Copy Markdown
Contributor Author

@pyrooka Sure i will follow the instructions, No i wont be opening any other PRs, please merge

@pyrooka pyrooka merged commit ae23d8e into IBM:main May 26, 2026
6 of 7 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request May 27, 2026
@semantic-release-bot
chore(release): 0.97.5 release notes [skip ci]
7ece7d6 
## [0.97.5](v0.97.4...v0.97.5) (2026-05-27)

### Bug Fixes

* **Metrics Router:** add `in-mum` region ([#446](#446)) ([ae23d8e](ae23d8e))
@ibm-devx-sdk

ibm-devx-sdk commented May 27, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 0.97.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrooka pyrooka pyrooka approved these changes

@fidel-ibm fidel-ibm Awaiting requested review from fidel-ibm

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PhaniDivi-613 @CLAassistant @pyrooka @ibm-devx-sdk