fix(ui): preserve visibility selection when editing entities by omorros · Pull Request #3402 · IBM/mcp-context-forge

omorros · 2026-03-02T16:47:12Z

🔗 Related Issue

📝 Summary

Edit form submit handlers (handleEditServerFormSubmit, handleEditToolFormSubmit,
handleEditGatewayFormSubmit, handleEditResFormSubmit, handleEditPromptFormSubmit) were not appending
the visibility field to FormData before submission. This caused the backend to default to "private",
silently overwriting the user's original visibility selection on every edit. This PR adds
formData.append("visibility", formData.get("visibility")) to all five edit handlers, matching the pattern
already used in the corresponding create handlers.

🏷️ Type of Change

🧪 Verification

Check	Command	Status
Lint suite	`make lint`	✅
Unit tests	`make test`	✅
Coverage ≥ 80%	`make coverage`

✅ Checklist

Code formatted (make black isort pre-commit)
Tests added/updated for changes
Documentation updated (if applicable)
No secrets or credentials committed

📓 Notes (optional)

The change is minimal, one line added to each of the five edit form submit handlers in
mcpgateway/static/admin.js. The create handlers already had this pattern; the edit handlers were simply
missing it. The team_id field is already handled via hidden inputs injected by the respective edit*()
functions, so no changes were needed there (except for handleEditPromptFormSubmit which already appended
team_id).

crivetimihai · 2026-03-05T14:11:02Z

Thanks @omorros — critical fix for #3391. Without this, every edit silently overwrites visibility to 'private'. Minimal and correct change. LGTM.

…ss edits Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>

The handleEditA2AAgentFormSubmit handler was missing the formData.append("visibility", ...) call that all other edit and create handlers have. This ensures visibility is preserved when editing A2A agents, matching the pattern in the other five edit handlers. Closes IBM#3391 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Cover all six edit form submit handlers to verify that the visibility field selected by the user is included in the submitted FormData: tool, prompt, gateway, server, resource, and A2A agent. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

crivetimihai · 2026-03-08T13:38:26Z

Review & Rebase Summary

Rebased onto main (clean, no conflicts) and reviewed the changes thoroughly.

What's in this PR

The original fix adds formData.append("visibility", formData.get("visibility")) to 5 edit form submit handlers, matching the pattern already used in all 6 create handlers. This prevents the backend from silently defaulting visibility to "private" on every edit.

Changes added during review

Fixed a gap in handleEditA2AAgentFormSubmit — this was the only edit handler missing the visibility append. Added the same one-liner for consistency with all other handlers.
Added tests/js/admin-edit-visibility.test.js — 7 tests covering all 6 edit form submit handlers (tool, prompt, gateway, server, resource, A2A agent), verifying the selected visibility value reaches the submitted FormData.

Verification

JS unit tests: 822/822 passing (24 test files)
curl backend tests: Verified visibility edit round-trip for tools, servers, and gateways (public → team → private → public)
Playwright E2E: Logged into admin UI, edited a tool's visibility from public to team via the edit modal, confirmed the table badge updated, re-opened the edit modal and confirmed the "Team" radio was pre-selected, confirmed via API that visibility=team persisted

No security, performance, or regression issues found.

crivetimihai

LGTM — verified via unit tests, curl API tests, and Playwright E2E. Added missing A2A handler fix and test coverage for all 6 edit handlers.

crivetimihai

LGTM — verified via unit tests, curl API tests, and Playwright E2E. Added missing A2A handler fix and test coverage for all 6 edit handlers.

…visibility entries formData.append() creates a second visibility key in the submitted FormData. Since Starlette's ImmutableMultiDict resolves duplicate keys to the last value, this introduces ordering-dependent behavior. Replace all 12 append("visibility", ...) calls (6 create + 6 edit handlers) with set(), which replaces the existing entry instead of duplicating it. Also strengthen tests to assert exactly one visibility entry (toEqual([value]) instead of toContain(value)), so they now fail if duplicates are reintroduced. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: append visibility in edit form handlers to retain selection across edits Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> * fix(ui): add visibility append to A2A edit handler for consistency The handleEditA2AAgentFormSubmit handler was missing the formData.append("visibility", ...) call that all other edit and create handlers have. This ensures visibility is preserved when editing A2A agents, matching the pattern in the other five edit handlers. Closes #3391 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * test(ui): add tests for visibility preservation in edit form handlers Cover all six edit form submit handlers to verify that the visibility field selected by the user is included in the submitted FormData: tool, prompt, gateway, server, resource, and A2A agent. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(ui): use formData.set() instead of append() to prevent duplicate visibility entries formData.append() creates a second visibility key in the submitted FormData. Since Starlette's ImmutableMultiDict resolves duplicate keys to the last value, this introduces ordering-dependent behavior. Replace all 12 append("visibility", ...) calls (6 create + 6 edit handlers) with set(), which replaces the existing entry instead of duplicating it. Also strengthen tests to assert exactly one visibility entry (toEqual([value]) instead of toContain(value)), so they now fail if duplicates are reintroduced. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * chore: fix trailing whitespace in sandbox.rs tests Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: append visibility in edit form handlers to retain selection across edits Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> * fix(ui): add visibility append to A2A edit handler for consistency The handleEditA2AAgentFormSubmit handler was missing the formData.append("visibility", ...) call that all other edit and create handlers have. This ensures visibility is preserved when editing A2A agents, matching the pattern in the other five edit handlers. Closes #3391 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * test(ui): add tests for visibility preservation in edit form handlers Cover all six edit form submit handlers to verify that the visibility field selected by the user is included in the submitted FormData: tool, prompt, gateway, server, resource, and A2A agent. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(ui): use formData.set() instead of append() to prevent duplicate visibility entries formData.append() creates a second visibility key in the submitted FormData. Since Starlette's ImmutableMultiDict resolves duplicate keys to the last value, this introduces ordering-dependent behavior. Replace all 12 append("visibility", ...) calls (6 create + 6 edit handlers) with set(), which replaces the existing entry instead of duplicating it. Also strengthen tests to assert exactly one visibility entry (toEqual([value]) instead of toContain(value)), so they now fail if duplicates are reintroduced. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * chore: fix trailing whitespace in sandbox.rs tests Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Yosief Eyob <yosiefogbazion@gmail.com>

omorros requested a review from crivetimihai as a code owner March 2, 2026 16:47

msureshkumar88 self-requested a review March 4, 2026 15:21

crivetimihai changed the title ~~fix: visibility selection not retained when editing virtual servers, tools, resources, prompts, and gateways~~ fix(ui): preserve visibility selection when editing entities Mar 5, 2026

crivetimihai added bug Something isn't working ui User Interface MUST P1: Non-negotiable, critical requirements without which the product is non-functional or unsafe labels Mar 5, 2026

crivetimihai added this to the Release 1.0.0-RC2 milestone Mar 5, 2026

crivetimihai modified the milestones: Release 1.0.0-RC2, Release 1.0.0 Mar 7, 2026

crivetimihai mentioned this pull request Mar 7, 2026

[BUG][UI]: Visibility selection not retained when editing virtual server #3391

Closed

7 tasks

crivetimihai added the release-fix Critical bugfix required for the release label Mar 7, 2026

crivetimihai self-assigned this Mar 7, 2026

crivetimihai modified the milestones: Release 1.0.0, Release 1.0.0-RC2 Mar 7, 2026

omorros and others added 3 commits March 8, 2026 12:53

fix: append visibility in edit form handlers to retain selection acro…

b1afb58

…ss edits Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk>

crivetimihai approved these changes Mar 8, 2026

View reviewed changes

crivetimihai previously approved these changes Mar 8, 2026

View reviewed changes

crivetimihai dismissed their stale review via 82390c7 March 8, 2026 13:39

crivetimihai force-pushed the fix/edit-visibility-retention branch from 2eb3b16 to 82390c7 Compare March 8, 2026 13:39

crivetimihai requested review from kevalmahajan and madhav165 as code owners March 8, 2026 13:39

crivetimihai added 2 commits March 8, 2026 14:16

chore: fix trailing whitespace in sandbox.rs tests

bc8b333

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

crivetimihai merged commit 89cc891 into IBM:main Mar 8, 2026
47 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): preserve visibility selection when editing entities#3402

fix(ui): preserve visibility selection when editing entities#3402
crivetimihai merged 5 commits intoIBM:mainfrom
omorros:fix/edit-visibility-retention

omorros commented Mar 2, 2026

Uh oh!

crivetimihai commented Mar 5, 2026

Uh oh!

crivetimihai commented Mar 8, 2026

Uh oh!

crivetimihai left a comment

Uh oh!

crivetimihai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

omorros commented Mar 2, 2026

🔗 Related Issue

📝 Summary

🏷️ Type of Change

🧪 Verification

✅ Checklist

📓 Notes (optional)

Uh oh!

crivetimihai commented Mar 5, 2026

Uh oh!

crivetimihai commented Mar 8, 2026

Review & Rebase Summary

What's in this PR

Changes added during review

Verification

Uh oh!

crivetimihai left a comment

Choose a reason for hiding this comment

Uh oh!

crivetimihai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants