[FIX][UI]: Display readOnlyHint icon in tools table rows#3045
Merged
crivetimihai merged 2 commits intomainfrom Feb 21, 2026
Merged
[FIX][UI]: Display readOnlyHint icon in tools table rows#3045crivetimihai merged 2 commits intomainfrom
crivetimihai merged 2 commits intomainfrom
Conversation
marekdano
previously approved these changes
Feb 19, 2026
Collaborator
marekdano
left a comment
There was a problem hiding this comment.
Tested it locally and the annotation is displayed when readOnlyHint is true!
LGTM 🚀
crivetimihai
previously approved these changes
Feb 19, 2026
Member
crivetimihai
left a comment
There was a problem hiding this comment.
Correct fix — the read-only hint badge was gated on annotations.title instead of annotations.readOnlyHint. Consistent fix across both template files.
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
fbcb369
b40a956 to
fbcb369
Compare
Member
Review ChangesRebased onto Tests
@gcgoncalves — please review the changes and let me know if anything looks off. |
vishu-bh
pushed a commit
that referenced
this pull request
Feb 24, 2026
* 2986 - Add Read Only Hint to tool rows Signed-off-by: Gabriel Costa <gabrielcg@proton.me> * test(ui): add tests for readOnlyHint annotation icon rendering Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Gabriel Costa <gabrielcg@proton.me> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
The read only icon was not displayed on the tool rows, difficulting a quick read.
Screen.Recording.2026-02-18.at.19.09.18.mov
Closes #2986
🔁 Reproduction Steps
ToolspanelreadOnlyHintannotation set totrue🐞 Root Cause
The Jinja template had the wrong attribute on the read-only icon display condition.
💡 Fix Description
Use the correct attribute on the Jinja row template.
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)