Skip to content

chore: add linting-full workflow and pre-commit gate#2948

Merged
crivetimihai merged 5 commits intomainfrom
improve-tooling
Feb 14, 2026
Merged

chore: add linting-full workflow and pre-commit gate#2948
crivetimihai merged 5 commits intomainfrom
improve-tooling

Conversation

@crivetimihai
Copy link
Copy Markdown
Member

@crivetimihai crivetimihai commented Feb 14, 2026 •
edited
Loading

Summary

  • add a dedicated linting-full workflow in GitHub Actions
  • add linting-* Make targets for additional tooling and keep linting-full limited to passing gates
  • run make pre-commit in linting-full
  • harden make pre-commit execution for local/CI reliability with deterministic cache/env setup
  • update pre-commit source-placeholder rule exclusions for Python files
  • fix executable mode for scripts/license_checker.py

Partially addresses #2383

@crivetimihai
chore: add linting-full workflow and pre-commit gate
fcfd6c8 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
fix: bootstrap pre-commit with uv in pipless venvs
ddcbaa7 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
fix: exclude known pre-commit false positives
42c09a5 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
fix: support helm plugin verify toggle in linting target
2fc0c4b 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
fix: resolve gosec findings and enforce linting gosec gate
aea483d 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai crivetimihai mentioned this pull request Feb 14, 2026
Open
49 tasks
@crivetimihai
Copy link
Copy Markdown
Member Author

crivetimihai commented Feb 14, 2026

Progress update for this PR (and #2383)

Implemented in this branch so far:

  • Added dedicated linting-full workflow (.github/workflows/linting-full.yml) running:
    • make --no-print-directory pre-commit
    • make --no-print-directory linting-full
  • Fixed make pre-commit bootstrap in pipless CI environments.
  • Added/standardized linting-* Makefile targets for selected tooling.
  • Fixed Helm unittest plugin install compatibility (handles Helm verify behavior, including --verify=false when supported).
  • Added targeted pre-commit excludes for current false positives in plugins_rust/secrets_detection/* paths.
  • Resolved current Go gosec findings across discovered Go modules and enforced linting-go-gosec in LINTING_FULL_TARGETS.

Current status:

  • make --no-print-directory pre-commit passes
  • make --no-print-directory linting-full passes

What’s left / next (based on latest local matrix run):

Likely next to enforce:

  1. linting-security-checkov (currently 6 findings, mostly workflow permissions/workflow_dispatch policy)
  2. linting-docs-markdown-links (3 localhost links)
  3. linting-docs-codespell (typo backlog + allowlist decisions)

Not gate-ready yet (larger backlog):

  • linting-workflow-zizmor
  • linting-security-kube-linter
  • linting-security-trufflehog
  • linting-python-fixit
  • linting-python-xenon
  • linting-python-refurb
  • linting-python-darglint

@crivetimihai crivetimihai self-assigned this Feb 14, 2026
@crivetimihai crivetimihai added cicd Issue with CI/CD process (GitHub Actions, scaffolding) chore Linting, formatting, dependency hygiene, or project maintenance chores labels Feb 14, 2026
@crivetimihai crivetimihai added this to the Release 1.0.0-RC1 milestone Feb 14, 2026
@crivetimihai crivetimihai merged commit 5a9f379 into main Feb 14, 2026
42 checks passed
@crivetimihai crivetimihai deleted the improve-tooling branch February 14, 2026 19:56
suciu-daniel pushed a commit that referenced this pull request Feb 16, 2026
@crivetimihai @suciu-daniel
chore: add linting-full workflow and pre-commit gate (#2948)
eaec13f 
* chore: add linting-full workflow and pre-commit gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: bootstrap pre-commit with uv in pipless venvs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: exclude known pre-commit false positives

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: support helm plugin verify toggle in linting target

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: resolve gosec findings and enforce linting gosec gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
vishu-bh pushed a commit that referenced this pull request Feb 18, 2026
@crivetimihai @vishu-bh
chore: add linting-full workflow and pre-commit gate (#2948)
146a2b7 
* chore: add linting-full workflow and pre-commit gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: bootstrap pre-commit with uv in pipless venvs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: exclude known pre-commit false positives

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: support helm plugin verify toggle in linting target

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: resolve gosec findings and enforce linting gosec gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
@crivetimihai
chore: add linting-full workflow and pre-commit gate (IBM#2948)
1d357ab 
* chore: add linting-full workflow and pre-commit gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: bootstrap pre-commit with uv in pipless venvs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: exclude known pre-commit false positives

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: support helm plugin verify toggle in linting target

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* fix: resolve gosec findings and enforce linting gosec gate

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@crivetimihai crivetimihai

Labels

chore Linting, formatting, dependency hygiene, or project maintenance chores cicd Issue with CI/CD process (GitHub Actions, scaffolding)

Projects

None yet

Milestone

Release 1.0.0-RC1

Development

Successfully merging this pull request may close these issues.

1 participant

@crivetimihai