fix: resolve selective export AttributeError and RBAC role deletion failures#2921
Merged
crivetimihai merged 2 commits intomainfrom Feb 13, 2026
Merged
fix: resolve selective export AttributeError and RBAC role deletion failures#2921crivetimihai merged 2 commits intomainfrom
crivetimihai merged 2 commits intomainfrom
Conversation
…ailures - Fix selective export using non-existent model attributes (rate_limit, timeout, is_active) by using getattr() and .enabled (#2916) - Fix broken SQLAlchemy query in role deletion: select().update() → update().where().values() (#2917) - Add ValueError handler for system role deletion returning 400 not 500 - Harden browser UI RBAC tests against intermittent cookie auth failures Closes #2916 Closes #2917 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
- test_delete_prompt: use retry-based wait_for_entity_deleted() instead of immediate assertion after API delete (race condition fix) - test_delete_server_ui_button: add scroll_into_view, force click, and expect_navigation (mirrors gateways_page pattern from #2890) - test_auth_type_filter/category_filter: wait for HTMX swap completion instead of fixed 1000ms timeout; skip if filter option not available - Add unit test for ValueError handler in rbac.py delete_role (line 286) to satisfy diff-cover threshold Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
suciu-daniel
pushed a commit
that referenced
this pull request
Feb 16, 2026
…ailures (#2921) * fix: resolve selective export AttributeError and RBAC role deletion failures - Fix selective export using non-existent model attributes (rate_limit, timeout, is_active) by using getattr() and .enabled (#2916) - Fix broken SQLAlchemy query in role deletion: select().update() → update().where().values() (#2917) - Add ValueError handler for system role deletion returning 400 not 500 - Harden browser UI RBAC tests against intermittent cookie auth failures Closes #2916 Closes #2917 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix: harden flaky browser UI tests and add ValueError coverage - test_delete_prompt: use retry-based wait_for_entity_deleted() instead of immediate assertion after API delete (race condition fix) - test_delete_server_ui_button: add scroll_into_view, force click, and expect_navigation (mirrors gateways_page pattern from #2890) - test_auth_type_filter/category_filter: wait for HTMX swap completion instead of fixed 1000ms timeout; skip if filter option not available - Add unit test for ValueError handler in rbac.py delete_role (line 286) to satisfy diff-cover threshold Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
vishu-bh
pushed a commit
that referenced
this pull request
Feb 18, 2026
…ailures (#2921) * fix: resolve selective export AttributeError and RBAC role deletion failures - Fix selective export using non-existent model attributes (rate_limit, timeout, is_active) by using getattr() and .enabled (#2916) - Fix broken SQLAlchemy query in role deletion: select().update() → update().where().values() (#2917) - Add ValueError handler for system role deletion returning 400 not 500 - Harden browser UI RBAC tests against intermittent cookie auth failures Closes #2916 Closes #2917 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix: harden flaky browser UI tests and add ValueError coverage - test_delete_prompt: use retry-based wait_for_entity_deleted() instead of immediate assertion after API delete (race condition fix) - test_delete_server_ui_button: add scroll_into_view, force click, and expect_navigation (mirrors gateways_page pattern from #2890) - test_auth_type_filter/category_filter: wait for HTMX swap completion instead of fixed 1000ms timeout; skip if filter option not available - Add unit test for ValueError handler in rbac.py delete_role (line 286) to satisfy diff-cover threshold Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
…ailures (IBM#2921) * fix: resolve selective export AttributeError and RBAC role deletion failures - Fix selective export using non-existent model attributes (rate_limit, timeout, is_active) by using getattr() and .enabled (IBM#2916) - Fix broken SQLAlchemy query in role deletion: select().update() → update().where().values() (IBM#2917) - Add ValueError handler for system role deletion returning 400 not 500 - Harden browser UI RBAC tests against intermittent cookie auth failures Closes IBM#2916 Closes IBM#2917 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix: harden flaky browser UI tests and add ValueError coverage - test_delete_prompt: use retry-based wait_for_entity_deleted() instead of immediate assertion after API delete (race condition fix) - test_delete_server_ui_button: add scroll_into_view, force click, and expect_navigation (mirrors gateways_page pattern from IBM#2890) - test_auth_type_filter/category_filter: wait for HTMX swap completion instead of fixed 1000ms timeout; skip if filter option not available - Add unit test for ValueError handler in rbac.py delete_role (line 286) to satisfy diff-cover threshold Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_limit,timeout,is_active) — usesgetattr()and.enabledto match full export patterns ([BUG][API]: Selective export crashes with AttributeError on Tool.rate_limit #2916)select().update()SQLAlchemy query replaced withupdate().where().values(), andValueErrorfrom system role check now returns 400 instead of 500 ([BUG][API]: RBAC role DELETE returns 500 due to incorrect SQLAlchemy query #2917)flaky(reruns=1))Test plan
POST /export/selectivereturns 200DELETE /rbac/roles/{id}returns 200Closes #2916
Closes #2917