fix: Implement pagination for gRPC listing in grpc_service and admin.py#2889
Merged
crivetimihai merged 4 commits intoIBM:mainfrom Feb 14, 2026
Merged
fix: Implement pagination for gRPC listing in grpc_service and admin.py#2889crivetimihai merged 4 commits intoIBM:mainfrom
crivetimihai merged 4 commits intoIBM:mainfrom
Conversation
dc28e94 to
bec89e4
Compare
Member
|
Thanks @gabe-l-hart. A few items to verify:
|
Branch: GrpcRegistrationUIFixes Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full
Branch: GrpcPagination Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full
…only filtering Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full
bec89e4 to
21366de
Compare
…conversion loop Add the `team` field to `GrpcServiceRead` schema to match all other Read schemas (ToolRead, ResourceRead, GatewayRead, PromptRead), so team name resolution actually populates the response. Add try/except around model_validate to gracefully skip corrupted records, consistent with other services. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
21366de to
7fecce2
Compare
suciu-daniel
pushed a commit
that referenced
this pull request
Feb 16, 2026
…py (#2889) * fix: Implement pagination for gRPC listing in grpc_service and admin.py Branch: GrpcRegistrationUIFixes Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Update tests and add a new one for multi-page grpc results Branch: GrpcPagination Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Add coverage for gRPC service team name resolution and team_id-only filtering Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * fix: add missing team field to GrpcServiceRead and error handling to conversion loop Add the `team` field to `GrpcServiceRead` schema to match all other Read schemas (ToolRead, ResourceRead, GatewayRead, PromptRead), so team name resolution actually populates the response. Add try/except around model_validate to gracefully skip corrupted records, consistent with other services. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
vishu-bh
pushed a commit
that referenced
this pull request
Feb 18, 2026
…py (#2889) * fix: Implement pagination for gRPC listing in grpc_service and admin.py Branch: GrpcRegistrationUIFixes Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Update tests and add a new one for multi-page grpc results Branch: GrpcPagination Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Add coverage for gRPC service team name resolution and team_id-only filtering Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * fix: add missing team field to GrpcServiceRead and error handling to conversion loop Add the `team` field to `GrpcServiceRead` schema to match all other Read schemas (ToolRead, ResourceRead, GatewayRead, PromptRead), so team name resolution actually populates the response. Add try/except around model_validate to gracefully skip corrupted records, consistent with other services. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
…py (IBM#2889) * fix: Implement pagination for gRPC listing in grpc_service and admin.py Branch: GrpcRegistrationUIFixes Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Update tests and add a new one for multi-page grpc results Branch: GrpcPagination Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * test: Add coverage for gRPC service team name resolution and team_id-only filtering Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> AI-usage: full * fix: add missing team field to GrpcServiceRead and error handling to conversion loop Add the `team` field to `GrpcServiceRead` schema to match all other Read schemas (ToolRead, ResourceRead, GatewayRead, PromptRead), so team name resolution actually populates the response. Add try/except around model_validate to gracefully skip corrupted records, consistent with other services. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch: GrpcRegistrationUIFixes
Signed-off-by: Gabe Goodhart ghart@us.ibm.com
AI-usage: full
🔗 Related Issue
Addresses #2854
📝 Summary
This PR fixes the implementation of pagination for GET
/admin/grpc🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Screenshots, design decisions, or additional context.