fix: remove HX-Retarget headers in team creation error handlers#2841
Merged
crivetimihai merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
Signed-off-by: Marek Dano <mk.dano@gmail.com>
8c57504 to
1cd9b5b
Compare
crivetimihai
approved these changes
Feb 11, 2026
Member
crivetimihai
left a comment
There was a problem hiding this comment.
LGTM — clean, correct, well-scoped fix.
Correctness verified:
- The create-team form (
admin.html:14197-14203) already setshx-target="#create-team-error"andhx-swap="innerHTML", so the server-sideHX-Retarget/HX-Reswapheaders were overriding to the same target — genuinely redundant.
Consistency check:
- The edit-team and edit-user forms do not have
hx-targetpointing to their error containers in the HTML template, so theirHX-Retargetheaders are genuinely needed. This PR correctly leaves those untouched.
No security or performance concerns. Error messages already use html.escape(). All 7 test_admin_create_team* tests pass.
Rebased onto current main (054d2b3), no conflicts.
crivetimihai
approved these changes
Feb 11, 2026
ja8zyjits
pushed a commit
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Marek Dano <mk.dano@gmail.com>
vishu-bh
pushed a commit
that referenced
this pull request
Feb 18, 2026
Signed-off-by: Marek Dano <mk.dano@gmail.com> Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
…2841) Signed-off-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
The team creation form's has
hx-target=#create-team-error, all error handlers inadmin_create_team()still sendHX-Retarget: #create-team-errorandHX-Reswap: innerHTMLheaders. These headers are now redundant — they retarget to the element that is already the form's default target.Closes #2800
🔁 Reproduction Steps
💡 Fix Description
Removed the redundant HX-Retarget and HX-Reswap headers from all error handlers (lines 4028-4029, 4044-4045, 4080-4081, 4090-4091, 4099-4100), since the form already targets #create-team-error
Changes Made:
mcpgateway/admin.py- Removed redundant headers from 5 error handlers:- Line 4028-4029: Email auth disabled error (403)
- Line 4044-4045: Missing team name error (400)
- Line 4080-4081: Validation error (400) + removed obsolete comment
- Line 4090-4091: IntegrityError (400)
- Line 4099-4100: Generic Exception (400)
tests/unit/mcpgateway/test_admin.py- Removed 5 redundant test assertions:- test_admin_create_team_disabled
- test_admin_create_team_missing_name
- test_admin_create_team_validation_error_message_cleaned
- test_admin_create_team_integrity_error_non_unique
- test_admin_create_team_unexpected_exception
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)