Merged
Conversation
Member
|
Thanks for working on the flaky tests, @gDINESH13! The However, I'd suggest a different approach for the assertion relaxations:
The root causes here are real-time dependency (TTL) and shared state (cache). The cache fix is correct; the TTL test needs time-mocking rather than looser assertions. Merging this for now, but would welcome a new PR to address the root cause. Thanks! |
Signed-off-by: gDINESH13 <dinesh13g@gmail.com>
90e208d to
a76c036
Compare
Contributor
Author
|
Thank you for feedback @crivetimihai it sure does makes lot of sense I will raise a new PR later implementing the changes. |
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
Signed-off-by: gDINESH13 <dinesh13g@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #2521
📝 Summary
What does this PR do and why?
This PR is intended to fix the TTL expiration when the test case suite is run.
🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)[ ] Tests added/updated for changes[ ] Documentation updated (if applicable)[ ] No secrets or credentials committed📓 Notes (optional)
Screenshots, design decisions, or additional context.