Skip to content

fix: for several outstanding pre-commit-lite issues that don't allow pre-commit to pass on Linux or Mac.#2740

Merged
crivetimihai merged 5 commits intomainfrom
bh_pre-commit-issues
Feb 7, 2026
Merged

fix: for several outstanding pre-commit-lite issues that don't allow pre-commit to pass on Linux or Mac.#2740
crivetimihai merged 5 commits intomainfrom
bh_pre-commit-issues

Conversation

@brian-hussey
Copy link
Copy Markdown
Member

@brian-hussey brian-hussey commented Feb 6, 2026

🔗 Related Issue

Closes #2731
Closes #2732
Closes #2733
Closes #2734
Closes #2735


📝 Summary

We are seeing failures on make pre-commit due to various reasons but specific failures outlined in defects above are:

  1. uv run --active pre-commit run --config .pre-commit-lite.yaml --all-files name-tests-test
  2. uv run --active pre-commit run --config .pre-commit-lite.yaml --all-files check-yaml
  3. uv run --active pre-commit run --config .pre-commit-lite.yaml --all-files detect-private-key
  4. uv run --active pre-commit run --config .pre-commit-lite.yaml --all-files check-shebang-scripts-are-executable
  5. uv run --active pre-commit run --config .pre-commit-lite.yaml check-executables-have-shebangs --all-files

🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)
    Bug fixes to development tasks from make, pre-commit

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 80% make coverage

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Screenshots, design decisions, or additional context.

Brian Hussey added 5 commits February 7, 2026 00:07
Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
…iles that are self executable

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
…iles with tests for the not allowed terms

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
…o fix yaml linting issue with tests/performance/plugins/config.yaml

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
… that are procedural and not specific units, including jmeter, loadtest(locust) and client

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
@crivetimihai crivetimihai merged commit 96dba56 into main Feb 7, 2026
45 checks passed
@crivetimihai crivetimihai deleted the bh_pre-commit-issues branch February 7, 2026 00:14
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
…pre-commit to pass on Linux or Mac. (IBM#2740)

* fix 2731 - Change file permissions on test/client/__init__.py

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>

* fix 2732 - Change file permissions on executable scripts and python files that are self executable

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>

* fix 2733 - set pre-commit detect-private-key to ignore the specific files with tests for the not allowed terms

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>

* fix 2734 - correct config of check-yaml to allow multiple files and to fix yaml linting issue with tests/performance/plugins/config.yaml

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>

* fix 2735 - correct config of name-tests-test to exclude further tests that are procedural and not specific units, including jmeter, loadtest(locust) and client

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>

---------

Signed-off-by: Brian Hussey <redacted@ie.ibm.com>
Co-authored-by: Brian Hussey <redacted@ie.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants