2702 - Fix Edit User password requirement#2703
Merged
crivetimihai merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
4 tasks
marekdano
approved these changes
Feb 5, 2026
Collaborator
marekdano
left a comment
There was a problem hiding this comment.
Tested and I'm confirming the fix. The requirement icons are changed to green when the requirements are met.
LGTM
c3474b0 to
298a2d6
Compare
marekdano
approved these changes
Feb 5, 2026
The Edit User modal's password requirement icons remained unchanged when typing because both Create User and Edit User forms used identical element IDs (req-length, req-uppercase, etc.). When JavaScript called document.getElementById(), it returned the Create form's elements instead of the Edit form's elements. Renamed Edit User form element IDs to use 'edit-' prefix to ensure uniqueness and updated the corresponding JavaScript functions in admin.js to reference the new IDs. Closes #2702 Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
298a2d6 to
8c60513
Compare
crivetimihai
approved these changes
Feb 6, 2026
crivetimihai
approved these changes
Feb 6, 2026
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
The Edit User modal's password requirement icons remained unchanged when typing because both Create User and Edit User forms used identical element IDs (req-length, req-uppercase, etc.). When JavaScript called document.getElementById(), it returned the Create form's elements instead of the Edit form's elements. Renamed Edit User form element IDs to use 'edit-' prefix to ensure uniqueness and updated the corresponding JavaScript functions in admin.js to reference the new IDs. Closes IBM#2702 Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Screen.Recording.2026-02-04.at.16.37.27.mov
📌 Summary
Password requirement icons in the Edit User modal do not update when typing in the password field. The icons remain gray (✗) even when password requirements are met, while the Create User form works correctly.
Closes #2702
🔁 Reproduction Steps
🐞 Root Cause
The Edit User modal's password requirement icons remained unchanged when typing because both Create User and Edit User forms used identical element IDs (req-length, req-uppercase, etc.). When JavaScript called document.getElementById(), it returned the Create form's elements instead of the Edit form's elements.
💡 Fix Description
Renamed Edit User form element IDs to use 'edit-' prefix to ensure uniqueness and updated the corresponding JavaScript functions in admin.js to reference the new IDs.
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)