2346 - Fixed root buttons of view, edit and export#2670
Merged
crivetimihai merged 7 commits intomainfrom Feb 7, 2026
Merged
Conversation
745dad2 to
f1dbb66
Compare
Member
|
Thanks for implementing the View/Edit/Export root buttons, @VladMRusu1. CI is all green and the fix looks well-structured with tests included. One thing to clean up: 10 unrelated files under git checkout origin/main -- plugins/unified_pdp/ tests/unit/plugins/test_unified_pdp.py tests/unit/plugins/test_unified_pdp_plugin.py
git commit -s -m "chore: remove unrelated files from rebase"After that cleanup, this should be ready to merge. |
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
- Move /changes endpoint before catch-all /{root_uri:path} to fix routing
- Remove debug print statement from update_root
- Restore correct test expectations for SSE endpoint
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
f64ebf1 to
9d5c3cc
Compare
- Normalize URIs in get/update/remove_root to match storage key - Fix JS null-deref when Content-Disposition header is missing - Fix misleading 'getting' log message in update_root - Return Root object directly instead of dict for type consistency Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
fb2c41c to
9a78595
Compare
crivetimihai
approved these changes
Feb 7, 2026
7 tasks
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
* 2346 - Fixed root buttons of view, edit and export
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
* Fixed lint, test and format issue
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
* chore: remove unrelated files from rebase
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
* fix: correct route ordering for /roots/changes endpoint
- Move /changes endpoint before catch-all /{root_uri:path} to fix routing
- Remove debug print statement from update_root
- Restore correct test expectations for SSE endpoint
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
* fix: address code review findings
- Normalize URIs in get/update/remove_root to match storage key
- Fix JS null-deref when Content-Disposition header is missing
- Fix misleading 'getting' log message in update_root
- Return Root object directly instead of dict for type consistency
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
* lint
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
* lint
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
---------
Signed-off-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai-Vlad Rusu <vladrusu@MacBookPro.lan>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 80 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
Fixed View/Edit/Export buttons from roots page to do an action and do not send an error in console anymore
🔁 Reproduction Steps
🐞 Root Cause
💡 Fix Description
Implemented API and JavaScript logic function for view, edit and export. I have added also the modal for view and edit in html.
Updated API logic for POST Root to get also expected errors
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)