Fix compose-tls for certs with passphrase#2667
Merged
crivetimihai merged 3 commits intomainfrom Feb 6, 2026
Merged
Conversation
Member
|
Clean fix with thorough documentation. The auto-decrypt approach in LGTM — ready to merge. |
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
- Use env:KEY_FILE_PASSWORD instead of pass: to avoid exposing password in process listings - Add validation to ensure cert.pem exists when key-encrypted.pem is provided, preventing silent key overwrite with self-signed cert Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
4f49f41 to
a7e00d7
Compare
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
* Fix compose-tls for certs with passphrase Signed-off-by: Madhav Kandukuri <madhav165@gmail.com> * Update documentation Signed-off-by: Madhav Kandukuri <madhav165@gmail.com> * fix: improve security and validation for passphrase-protected keys - Use env:KEY_FILE_PASSWORD instead of pass: to avoid exposing password in process listings - Add validation to ensure cert.pem exists when key-encrypted.pem is provided, preventing silent key overwrite with self-signed cert Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Closes #2679
📌 Summary
Adds support for passphrase-protected TLS private keys in
docker-compose.yml. Previously, users with encrypted certificates had to manually decrypt them before use.Closes #XXX
🔁 Reproduction Steps
make certs-passphrase # Enter passphrase when promptedmake compose-tls🐞 Root Cause
The
cert_initservice only checked for existingcert.pem/key.pemfiles and generated new self-signed certs if missing. It had no mechanism to handle passphrase-protected keys (key-encrypted.pem), and nginx cannot natively read encrypted private keys.💡 Fix Description
Enhanced
cert_initto automatically decrypt passphrase-protected keys:key-encrypted.pem+KEY_FILE_PASSWORDenv varkey.pemusingopenssl rsabefore nginx starts🧪 Verification
make lintmake test📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)