Merged
Conversation
Member
|
Thanks for the fix, @Nayana-R-Gowda. The tag display bug is real — However, rather than {% if tag is mapping %}{{ tag.id }}{% else %}{{ tag }}{% endif %}This handles both object and string tag formats safely. Also, No linked issue — please add one to the PR description. |
Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
…ngs; render tags defensively Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
Apply the `{% if tag is mapping %}{{ tag.id }}{% else %}{{ tag }}{% endif %}`
pattern to resources_partial.html, plugins_partial.html, and
tools_with_pagination.html that were missing the defensive check.
Also fix accidental indentation change in admin.html.
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
9520ca1 to
fee52d7
Compare
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
* Resource tags are being displayed
Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
* Fix tag display bug where {{ tag.id }} crashes if tags are plain strings; render tags defensively
Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
* fix: Apply defensive tag pattern consistently across all templates
Apply the `{% if tag is mapping %}{{ tag.id }}{% else %}{{ tag }}{% endif %}`
pattern to resources_partial.html, plugins_partial.html, and
tools_with_pagination.html that were missing the defensive check.
Also fix accidental indentation change in admin.html.
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
---------
Signed-off-by: NAYANAR <nayana.r7813@gmail.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANAR nayana.r7813@gmail.com
Resource tags are now visible