Merged
Conversation
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
c8982ec to
6371390
Compare
- Use admin_page fixture consistently for authenticated access - Add explicit waits for modal visibility with :not(.hidden) selector - Skip tests properly when no tools are available instead of silent pass - Increase timeout to 10s for modal operations Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
- Add _wait_for_codemirror() to wait for CodeMirror editor initialization before interacting with promptArgsEditor - Remove redundant navigation in test_admin_panel_loads since admin_page fixture already handles authentication and navigation - Add cleanup to all entity create tests (prompts, resources, servers, tools) to delete created entities after test completion - Fix _prepare_tools_table() to use state="attached" instead of requiring visibility, preventing timeouts on empty tables - Apply black/isort formatting fixes Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Member
Author
Test Reliability FixesFixed flaky and failing playwright tests: Issues Fixed
Test ResultsTests verified to pass on multiple consecutive runs. |
- Wait for CodeMirror library to load before checking editor instance - Increase timeout from 10s to 30s for slower CI environments - Add null check to editor wait condition Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Member
Author
Additional Fix for test_prompts.pyImproved CodeMirror wait reliability:
This should fix the |
hughhennelly
pushed a commit
to hughhennelly/mcp-context-forge
that referenced
this pull request
Feb 8, 2026
* Increase playwright coverage Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve playwright tool modal tests reliability - Use admin_page fixture consistently for authenticated access - Add explicit waits for modal visibility with :not(.hidden) selector - Skip tests properly when no tools are available instead of silent pass - Increase timeout to 10s for modal operations Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve playwright test reliability and idempotency - Add _wait_for_codemirror() to wait for CodeMirror editor initialization before interacting with promptArgsEditor - Remove redundant navigation in test_admin_panel_loads since admin_page fixture already handles authentication and navigation - Add cleanup to all entity create tests (prompts, resources, servers, tools) to delete created entities after test completion - Fix _prepare_tools_table() to use state="attached" instead of requiring visibility, preventing timeouts on empty tables - Apply black/isort formatting fixes Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve CodeMirror wait reliability in prompts test - Wait for CodeMirror library to load before checking editor instance - Increase timeout from 10s to 30s for slower CI environments - Add null check to editor wait condition Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: hughhennnelly <hughhennelly06@gmail.com>
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
* Increase playwright coverage Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve playwright tool modal tests reliability - Use admin_page fixture consistently for authenticated access - Add explicit waits for modal visibility with :not(.hidden) selector - Skip tests properly when no tools are available instead of silent pass - Increase timeout to 10s for modal operations Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve playwright test reliability and idempotency - Add _wait_for_codemirror() to wait for CodeMirror editor initialization before interacting with promptArgsEditor - Remove redundant navigation in test_admin_panel_loads since admin_page fixture already handles authentication and navigation - Add cleanup to all entity create tests (prompts, resources, servers, tools) to delete created entities after test completion - Fix _prepare_tools_table() to use state="attached" instead of requiring visibility, preventing timeouts on empty tables - Apply black/isort formatting fixes Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * fix(tests): improve CodeMirror wait reliability in prompts test - Wait for CodeMirror library to load before checking editor instance - Increase timeout from 10s to 30s for slower CI environments - Add null check to editor wait condition Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase playwright coverage