Skip to content

test: improve test coverage massively from ~66% to ~80%#2623

Merged
crivetimihai merged 22 commits intomainfrom
cover-80-testing
Feb 1, 2026
Merged

test: improve test coverage massively from ~66% to ~80%#2623
crivetimihai merged 22 commits intomainfrom
cover-80-testing

Conversation

@crivetimihai
Copy link
Copy Markdown
Member

@crivetimihai crivetimihai commented Feb 1, 2026 •
edited
Loading

Summary

  • Improve unit test coverage from ~66% to ~80%
  • Fix incorrect variable reference in RPC handler: use oauth_user_email instead of user_email when forwarding requests to gateway service

Closes #2625

Changes

Bug fix:

  • mcpgateway/main.py: Correct email variable in handle_rpc gateway forwarding

New test coverage (8,800+ lines added):

Area Tests Added
Cache Admin stats, auth L1/L2, cache invalidation subscriber, registry, session registry, tool lookup
Middleware Token scoping
Routers Email auth, LLM admin, LLM chat, log search, RBAC, SSO
Services Audit trail, cancellation, gateway helpers, gRPC (no-grpc fallback), LLM proxy, MCP client chat, metrics rollup, OAuth PKCE
Core Admin module, auth helpers, DB, schemas validation, toolops ALTK, translate gRPC

@crivetimihai crivetimihai changed the title test: improve cache coverage test: improve test coverage to 80% Feb 1, 2026
@crivetimihai crivetimihai changed the title test: improve test coverage to 80% test: improve test coverage massively to 80% Feb 1, 2026
@crivetimihai crivetimihai changed the title test: improve test coverage massively to 80% test: improve test coverage massively from ~66% to ~80% Feb 1, 2026
@crivetimihai crivetimihai self-assigned this Feb 1, 2026
@crivetimihai
test: improve cache coverage
ec60fcb 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: improve coverage for cli and runtime paths
3dba89e 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: fix toolops permission stubs
8ed5796 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: expand coverage for tool helpers and admin servers
f552506 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: extend coverage for low-coverage services
7c2721f 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: extend coverage for services
6a4408d 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai crivetimihai added this to the Release 1.0.0-RC1 milestone Feb 1, 2026
@crivetimihai
test: expand coverage for grpc oauth metrics
93b6404 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: expand unit coverage for admin and services
32d5739 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: expand observability and oauth coverage
27667da 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Fix flaky test
1798043 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
80% threshold
2cf92a8 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai crivetimihai added testing Testing (unit, e2e, manual, automated, etc) python Python / backend development (FastAPI) test-automation Automated testing labels Feb 1, 2026
@crivetimihai
Docs update for testing
03831f3 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: expand coverage for transports, plugins, wrapper
bdccf44 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Fix tests
677a4a9 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Fix tests
9b74938 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Fix tests
524a758 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Test improvements
d77ac6a 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Increase coverage
1ea1136 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
test: expand coverage for observability and services
7c8ddf7
@crivetimihai
test: expand bulk registration coverage
991a774 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Increase coverage
ea158f6 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai
Copy link
Copy Markdown
Member Author

crivetimihai commented Feb 1, 2026

Coverage update + test additions

What I did:

  • Added bulk registration tests for resources and prompts, including update/rename/fail/empty/error paths and tag normalization handling.
  • Expanded ImportService tests for dry-run resources/prompts, update-not-found, update error, and conflict strategies (skip/rename/fail).
  • Hardened admin HTMX catalog test fixture to avoid SharedHttpClient shutdown errors across lifespan runs.

Current coverage (from make coverage):

  • Lines: 41951/48685 (86.17%)
  • Branches: 10884/14800 (73.54%)
  • Total: 83.22%

@crivetimihai
Increase coverage
f80c154 
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai crivetimihai merged commit 5207676 into main Feb 1, 2026
51 checks passed
@crivetimihai crivetimihai deleted the cover-80-testing branch February 1, 2026 22:37
hughhennelly pushed a commit to hughhennelly/mcp-context-forge that referenced this pull request Feb 8, 2026
@crivetimihai @hughhennelly
test: improve test coverage massively from ~66% to ~80% (IBM#2623)
f2dbfaf 
* test: improve cache coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: improve coverage for cli and runtime paths

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: fix toolops permission stubs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for tool helpers and admin servers

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: extend coverage for low-coverage services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: extend coverage for services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for grpc oauth metrics

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand unit coverage for admin and services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand observability and oauth coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix flaky test

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* 80% threshold

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Docs update for testing

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for transports, plugins, wrapper

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Test improvements

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for observability and services

* test: expand bulk registration coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: hughhennnelly <hughhennelly06@gmail.com>
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
@crivetimihai
test: improve test coverage massively from ~66% to ~80% (IBM#2623)
bcd87ae 
* test: improve cache coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: improve coverage for cli and runtime paths

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: fix toolops permission stubs

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for tool helpers and admin servers

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: extend coverage for low-coverage services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: extend coverage for services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for grpc oauth metrics

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand unit coverage for admin and services

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand observability and oauth coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix flaky test

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* 80% threshold

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Docs update for testing

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for transports, plugins, wrapper

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Fix tests

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Test improvements

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* test: expand coverage for observability and services

* test: expand bulk registration coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

* Increase coverage

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevalmahajan kevalmahajan Awaiting requested review from kevalmahajan kevalmahajan is a code owner

@madhav165 madhav165 Awaiting requested review from madhav165 madhav165 is a code owner

Assignees

@crivetimihai crivetimihai

Labels

python Python / backend development (FastAPI) test-automation Automated testing testing Testing (unit, e2e, manual, automated, etc)

Projects

None yet

Milestone

Release 1.0.0-RC1

Development

Successfully merging this pull request may close these issues.

[EPIC][TESTING]: Achieve 80%+ Code Coverage with CI/CD Enforcement

1 participant

@crivetimihai