chore: remove unused json_default function from llmchat_router#2619
Merged
crivetimihai merged 1 commit intoIBM:mainfrom Jan 31, 2026
Merged
Conversation
17f234e to
194bde5
Compare
Member
|
Thanks @jonathan-fulton! Confirmed this is dead code - the |
The json_default function was defined but never called in the code. It only appeared in docstring examples but was never used. Removing dead code to reduce maintenance burden. Fixes IBM#2372 Signed-off-by: Jonathan Fulton <jonathan@jonathanfulton.com>
194bde5 to
41a6a5b
Compare
crivetimihai
approved these changes
Jan 31, 2026
hughhennelly
pushed a commit
to hughhennelly/mcp-context-forge
that referenced
this pull request
Feb 8, 2026
) The json_default function was defined but never called in the code. It only appeared in docstring examples but was never used. Removing dead code to reduce maintenance burden. Fixes IBM#2372 Signed-off-by: Jonathan Fulton <jonathan@jonathanfulton.com> Signed-off-by: hughhennnelly <hughhennelly06@gmail.com>
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
) The json_default function was defined but never called in the code. It only appeared in docstring examples but was never used. Removing dead code to reduce maintenance burden. Fixes IBM#2372 Signed-off-by: Jonathan Fulton <jonathan@jonathanfulton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
json_defaultfunction fromllmchat_router.py.Problem
The
json_defaultfunction was defined but never called anywhere in the code. It only appeared in docstring examples but was never actually used for JSON serialization.Solution
Remove the dead code to reduce maintenance burden.
Fixes #2372