fix: add sso_entra_admin_groups to list field validator#2269
Merged
crivetimihai merged 2 commits intomainfrom Jan 24, 2026
Merged
fix: add sso_entra_admin_groups to list field validator#2269crivetimihai merged 2 commits intomainfrom
crivetimihai merged 2 commits intomainfrom
Conversation
- sso_entra_admin_groups now properly parses CSV/JSON from environment - Closes #2265 Signed-off-by: Akshay Shinde <akshayshinde@dhcp-9-162-244-59.mul.ie.ibm.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
ec38cba to
734abef
Compare
crivetimihai
approved these changes
Jan 24, 2026
kcostell06
pushed a commit
to kcostell06/mcp-context-forge
that referenced
this pull request
Feb 24, 2026
* fix: add sso_entra_admin_groups to list field validator - sso_entra_admin_groups now properly parses CSV/JSON from environment - Closes IBM#2265 Signed-off-by: Akshay Shinde <akshayshinde@dhcp-9-162-244-59.mul.ie.ibm.com> * style: fix missing blank lines in test_config.py Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Akshay Shinde <akshayshinde@dhcp-9-162-244-59.mul.ie.ibm.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Akshay Shinde <akshayshinde@dhcp-9-162-244-59.mul.ie.ibm.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
sso_entra_admin_groupssetting was missing from the_parse_list_from_envfield validator, despite usingAnnotated[list[str], NoDecode()]annotation and supporting CSV/JSON format parsing.All other similar list settings were properly validated:
sso_trusted_domains✅sso_auto_admin_domains✅sso_github_admin_orgs✅sso_google_admin_domains✅insecure_queryparam_auth_allowed_hosts✅Solution
Added
"sso_entra_admin_groups"to the@field_validatordecorator at line 1530, ensuring environment variable values are properly parsed from CSV or JSON format strings.Impact
SSO_ENTRA_ADMIN_GROUPSenvironment variable now correctly parses CSV and JSON formatsTesting
Added test case to verify both CSV and JSON parsing formats work correctly for the field.
Closes #2265