Skip to content

Fix Admin UI to Display Tag Values Instead of Objects#2268

Merged
crivetimihai merged 2 commits intomainfrom
issue_view_tag_admin_ui
Jan 21, 2026
Merged

Fix Admin UI to Display Tag Values Instead of Objects#2268
crivetimihai merged 2 commits intomainfrom
issue_view_tag_admin_ui

Conversation

@rakdutta
Copy link
Copy Markdown
Collaborator

closes issue #2267
This pull request updates how tags are displayed in the admin interface to better handle cases where tags may be objects rather than simple strings. The changes ensure that, when a tag is an object, either its id or label is shown, improving robustness and consistency across different admin views.

Improvements to tag display logic:

  • Updated tag rendering in viewAgent, viewResource, and viewGateway functions to check if a tag is an object and display its id or label if available, otherwise showing the tag as-is. [1] [2] [3]
  • Modified the tag rendering in viewTool to use the same logic when generating HTML, ensuring object tags are handled correctly in the tool view as well.

@rakdutta rakdutta marked this pull request as ready for review January 21, 2026 13:10
Copy link
Copy Markdown
Collaborator

@gcgoncalves gcgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-01-21 at 13 25 15

Nice!

Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
@crivetimihai crivetimihai force-pushed the issue_view_tag_admin_ui branch from 2ca12c5 to 2c76c92 Compare January 21, 2026 17:29
- Add object-to-string conversion for tags in showTokenDetailsModal
  (was missed in original PR)
- Remove inconsistent blank line in viewGateway tag rendering
- Add JSON.stringify fallback for malformed tag objects without id/label
  (defense-in-depth for edge cases like DB corruption)

Part of the fix for #2267

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Mihai Criveti <crmihai1@ie.ibm.com>
@crivetimihai crivetimihai force-pushed the issue_view_tag_admin_ui branch from 2c76c92 to 0d85f18 Compare January 21, 2026 18:00
@crivetimihai crivetimihai merged commit b96afc7 into main Jan 21, 2026
51 checks passed
@crivetimihai crivetimihai deleted the issue_view_tag_admin_ui branch January 21, 2026 18:14
010gvr pushed a commit to 010gvr/mcp-context-forge that referenced this pull request Jan 23, 2026
* tag view

Signed-off-by: rakdutta <rakhibiswas@yahoo.com>

* fix: Handle object tags in token details and improve fallback handling

- Add object-to-string conversion for tags in showTokenDetailsModal
  (was missed in original PR)
- Remove inconsistent blank line in viewGateway tag rendering
- Add JSON.stringify fallback for malformed tag objects without id/label
  (defense-in-depth for edge cases like DB corruption)

Part of the fix for IBM#2267

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Mihai Criveti <crmihai1@ie.ibm.com>

---------

Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Mihai Criveti <crmihai1@ie.ibm.com>
Co-authored-by: Mihai Criveti <crmihai1@ie.ibm.com>
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
* tag view

Signed-off-by: rakdutta <rakhibiswas@yahoo.com>

* fix: Handle object tags in token details and improve fallback handling

- Add object-to-string conversion for tags in showTokenDetailsModal
  (was missed in original PR)
- Remove inconsistent blank line in viewGateway tag rendering
- Add JSON.stringify fallback for malformed tag objects without id/label
  (defense-in-depth for edge cases like DB corruption)

Part of the fix for IBM#2267

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Mihai Criveti <crmihai1@ie.ibm.com>

---------

Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Signed-off-by: Mihai Criveti <crmihai1@ie.ibm.com>
Co-authored-by: Mihai Criveti <crmihai1@ie.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants