🐛 Bug-fix PR

Fixes #2213

Summary

Fixes pagination controls to properly namespace and clean up query parameters when navigating between different tables (tools, prompts, resources) in the admin UI.

Problem

Pagination query parameters were accumulating across different tables, resulting in URLs like:

?tools_page=3&tools_size=10&tools_inactive=false&prompts_page=2&prompts_size=10&prompts_inactive=false&resources_page=2&resources_size=10&resources_inactive=false

Each tab should only have its own table's parameters in the URL.

Changes

1. Fixed updateBrowserUrl() in pagination_controls.html

• Changed from creating fresh URLSearchParams to preserving existing params
• Now only updates current table's params (page, size, inactive)
• Preserves all params from other tables

2. Fixed updateInactiveUrlState() in admin.html

• Changed from creating fresh URLSearchParams to preserving existing params
• Now only updates current table's inactive state and resets page to 1
• Preserves all params from other tables

3. Enhanced showTab() in admin.js

• Added getTableNamesForTab() function that scans DOM for pagination controls (id="*-pagination-controls")
• Added cleanUpUrlParamsForTab() function that removes params for tables not in current tab
• Calls cleanup function when switching tabs to remove stale params
• Uses convention-based detection instead of hardcoded mapping

Behavior After Fix

Navigation within a table

• Tools page 1 → Tools page 3: Only updates tools_page
• Changing page size: Only updates tools_size, resets tools_page to 1
• Toggling inactive: Only updates tools_inactive, resets tools_page to 1

Switching between tabs

• On Tools tab: ?tools_page=3&tools_size=10&tools_inactive=false#tools
• Switch to Prompts: ?prompts_page=1&prompts_size=10&prompts_inactive=false#prompts
• Switch back to Tools: ?tools_page=3&tools_size=10&tools_inactive=false#tools

Global params preservation

• team_id parameter is always preserved across all operations

Implementation Details

Dynamic Detection:
The solution uses convention-based DOM scanning to detect pagination tables. When switching tabs, it:

1. Queries the panel for elements matching [id$="-pagination-controls"]
2. Extracts table names from the ID pattern (e.g., "tools-pagination-controls" → "tools")
3. Keeps only params for detected tables plus global params (team_id)

Example: Switching to Tools tab finds <div id="tools-pagination-controls">, extracts "tools", and keeps only tools_page, tools_size, tools_inactive, and team_id params.

This approach requires zero maintenance when adding new paginated tables - just follow the existing {tableName}-pagination-controls naming convention.

Notes

• All existing functionality is preserved
• No breaking changes to API or data handling
• URLs are now cleaner and more bookmarkable
• Each tab maintains its own independent pagination state

🧪 Verification

📐 MCP Compliance (if relevant)

• Matches current MCP spec
• No breaking change to MCP clients

✅ Checklist

• Code formatted (make black isort pre-commit)
• No secrets/credentials committed