Code Review Feedback

Thanks for working on extending the "Show Inactive" toggle! I've reviewed the changes and found some architectural issues that need to be addressed before merging.

Issues Found

1. HIGH: Pagination Mismatch (Functional Regression)

With include_inactive=true hardcoded in HTMX requests, the backend returns paginated results that include inactive items in the count. When the frontend hides inactive rows via CSS, pagination becomes inconsistent.

Example: If a user has 100 tools (80 active, 20 inactive) with "Show Inactive" unchecked:

• Expected: Page 1 shows 20 active tools, pagination says "1-20 of 80"
• Actual: Page 1 shows ~16 active tools (some hidden), pagination says "1-20 of 100"

The backend applies include_inactive filtering BEFORE pagination in all services (server_service.py:767-768, tool_service.py:1709-1711, resource_service.py:968-970, etc.), so when include_inactive=true, inactive items are counted in total_items and distributed across pages.

Recommendation: Restore include_inactive={{ include_inactive|default(false)|string|lower }} and use HTMX to reload when toggling.

2. MEDIUM: Filter Not Re-applied After HTMX Swaps

The inactive filter is only applied once via setTimeout at admin.js:141-149 on initial page load. When users paginate (HTMX swap), the filter is not re-applied, so inactive rows reappear.

Fix: Add htmx:afterSwap event listener to re-apply filters after pagination.

3. MEDIUM: Search and Inactive Filters Don't Compose

The PR removes the inactive check from filterServerTable(), and for tools/resources/prompts/A2A the new inactive toggle runs separately from search, so whichever runs last wins. (Note: filterGatewaysTable already composes both filters correctly.)

User experience: If you search for "api" then toggle "Show Inactive", rows that don't match "api" reappear.

Fix: Each filter function should respect both search AND inactive state.

4. LOW: ToolOps Toggle Is Non-Functional

The Tool Operations panel checkbox calls toggleInactiveItems('tools-toolops'), but:

1. "tools-toolops" is not mapped in tbodyIdMap at admin.js:10186-10193
2. ToolOps rows use data-status attribute instead of data-enabled at admin.js:10708

Recommended Fix Approach

Option A (Recommended): Keep server-side filtering for pagination accuracy

• Restore include_inactive={{ include_inactive|default(false)|string|lower }} in templates
• Add htmx:afterSwap handler to maintain toggle state
• Coordinate search + inactive filters in each filter function

@crivetimihai The search will be handled on a separate issue (#2159)

Review Changes

Rebased onto main and addressed the following issues:

Bugs Fixed

• Duplicated docstring in admin_search_tools - removed duplicate Args/Returns sections
• Event delegation lost after HTMX swap - moved listener from #toolBody to #tool-ops-main-content-wrapper which survives swaps
• Toggle targets incorrect - Resources/Prompts toggles now target #resources-table/#prompts-table instead of non-existent container IDs
• Race condition - toggles are now disabled until their target element loads, enabled via htmx:afterSettle

Improvements

• Restored 3-state status in Tool Ops - now shows Online (green), Offline (yellow), Inactive (red) based on enabled and reachable fields
• URL state persistence - toggle state now syncs with URL via history.replaceState for bookmarkability
• Consistent pagination - all toggles read current per_page from pagination selector, fallback to 50 (matching settings.pagination_default_page_size)
• Reduced log noise - changed tool-ops partial logging from INFO to DEBUG, removed PII (user email, referer)

Summary

• Reset to page 1 on toggle (standard filter UX)
• Preserve current per_page selection
• All tests pass (5213 passed)