Update Helm Chart to Use External Secrets#1798
Conversation
… mcpContextForge Signed-off-by: Shi Jin <jinzishuai@gmail.com>
Signed-off-by: Shi Jin <jinzishuai@gmail.com>
…onfig Signed-off-by: Shi Jin <jinzishuai@gmail.com>
…nnection env vars Signed-off-by: Shi Jin <jinzishuai@gmail.com>
d45885e to
b63b1b9
Compare
|
Thank you, would this also close: [Feature Request]: Support for External Secrets via customEnvFrom #1917? |
|
I checked your PR and I can confirm it would close #1917 I would recommend you renaming this parameter from As you can see these parameters were used there for years https://github.com/bitnami/charts/tree/main/bitnami and became a standard in almost every helm chart |
|
Thank you @jinzishuai for this contribution! 🙏 After reviewing this PR, I found that most of the functionality has already been implemented in the main branch since this PR was opened: Already Implemented:
Still Valid & Useful:
I'm closing this PR and will open a new, smaller PR that includes only the still-valid changes (service annotations + CACHE_TYPE "none"), with proper attribution to you as the original author. Thank you for identifying these gaps - the service annotations feature is particularly useful for cloud deployments! |
|
Closing as superseded. See the comment above for details. A new PR with the still-valid changes available as #2088 |
- Add mcpContextForge.service.annotations for LoadBalancer configuration (e.g., AWS NLB, GCP load balancer annotations) - Add "none" as a valid CACHE_TYPE option in values.schema.json to allow disabling caching entirely These changes were extracted from PR #1798, which was superseded by existing implementations for external PostgreSQL and secret injection. Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
- Add mcpContextForge.service.annotations for LoadBalancer configuration (e.g., AWS NLB, GCP load balancer annotations) - Add "none" as a valid CACHE_TYPE option in values.schema.json to allow disabling caching entirely These changes were extracted from PR #1798, which was superseded by existing implementations for external PostgreSQL and secret injection. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Shi Jin <jinzishuai@gmail.com>
) - Add mcpContextForge.service.annotations for LoadBalancer configuration (e.g., AWS NLB, GCP load balancer annotations) - Add "none" as a valid CACHE_TYPE option in values.schema.json to allow disabling caching entirely These changes were extracted from PR IBM#1798, which was superseded by existing implementations for external PostgreSQL and secret injection. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Shi Jin <jinzishuai@gmail.com>
This is one way to address #1722 and it works on my EKS environment and RDS and Google SSO.
externalSecretvalue which allows setting up SSOnoneforcache_typeThis way, we don't need to store any sensitive data in plain text and becomes production ready.