Skip to content

Chart plugin conf#1185

Merged
crivetimihai merged 8 commits intoIBM:mainfrom
popagruia:chart_plugin_conf
Nov 5, 2025
Merged

Chart plugin conf#1185
crivetimihai merged 8 commits intoIBM:mainfrom
popagruia:chart_plugin_conf

Conversation

@popagruia
Copy link
Copy Markdown
Contributor

@popagruia popagruia commented Oct 8, 2025

✨ Feature / Enhancement PR

🚀 Summary (1-2 sentences)

Adds the possibility to define plugin config.yaml as part of the values file used in chart

A new section may be added in the chart values file so we can define a specific configuration file for plugins. The file will be added on the path defined in PLUGIN_CONFIG_FILE relative to app directory: /app/$ PLUGIN_CONFIG_FILE. the feature can be enabled by setting plugin.Config.enabled to true. By default is disabled and in this case the existing behaviour is preserved.

  pluginConfig: 
    enabled: true
    plugins: |
      # plugins/config.yaml - Main plugin configuration file

      plugins:
        - name: "Plugin name"
      ....

      plugin_health_check_interval: 60

🧪 Checks

  • [x ] make lint passes
  • [x ] make test passes
  • [NA ] CHANGELOG updated (if user-facing)

@popagruia popagruia marked this pull request as draft October 8, 2025 10:46
@popagruia popagruia marked this pull request as ready for review October 8, 2025 11:12
@popagruia popagruia marked this pull request as draft November 3, 2025 10:19
@popagruia popagruia force-pushed the chart_plugin_conf branch 2 times, most recently from e907365 to 1ef502e Compare November 3, 2025 11:33
@popagruia popagruia marked this pull request as ready for review November 4, 2025 09:17
popagruia and others added 8 commits November 5, 2025 01:54
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
- Add newline at end of configmap-gateway-plugin.yaml
- Improve schema descriptions for pluginConfig
- Restore ingress annotations field (as empty object)
- Fix volumeMounts indentation in deployment
- Ensure backward compatibility with existing deployments

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
@crivetimihai crivetimihai merged commit fcc82bf into IBM:main Nov 5, 2025
44 checks passed
kcostell06 pushed a commit to kcostell06/mcp-context-forge that referenced this pull request Feb 24, 2026
* Initial version

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* Fixed dependency of plugins enable

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* Changed schema/defaults

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* Fixed plugin path

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* bring files from main

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* Fixed rebase

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* Remove uwanted default value

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>

* fix: improve plugin config chart implementation

- Add newline at end of configmap-gateway-plugin.yaml
- Improve schema descriptions for pluginConfig
- Restore ingress annotations field (as empty object)
- Fix volumeMounts indentation in deployment
- Ensure backward compatibility with existing deployments

Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

---------

Signed-off-by: popagruia <adrian.popa@ro.ibm.com>
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Co-authored-by: popagruia <adrian.popa@ro.ibm.com>
Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants