Skip to content

feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload#244

Merged
dpopp07 merged 2 commits intoIBM:mainfrom
SaschaSchwarze0:sascha-container-authenticator-codeengine
Mar 7, 2025
Merged

feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload#244
dpopp07 merged 2 commits intoIBM:mainfrom
SaschaSchwarze0:sascha-container-authenticator-codeengine

Conversation

@SaschaSchwarze0
Copy link
Copy Markdown
Member

This pull request extends the existing ContainerAuthenticator to be aware of the hard-coded compute resource token path used by Code Engine. This allows a seamless usage of that authenticator and a move of workload between IKS/ROKS/Code Engine without changing a single line of code.

Documentation is adjusted to mention Code Engine in the context of the ContainerAuthenticator.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-container-authenticator-codeengine branch from bf4e91c to 6c57be6 Compare March 3, 2025 12:21
…rt Code Engine workload

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-container-authenticator-codeengine branch from 6c57be6 to f3575aa Compare March 3, 2025 12:22
@padamstx padamstx self-requested a review March 6, 2025 23:14
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx self-assigned this Mar 6, 2025
@padamstx padamstx requested a review from dpopp07 March 6, 2025 23:48
Copy link
Copy Markdown
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dpopp07 dpopp07 merged commit 80518d2 into IBM:main Mar 7, 2025
6 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2025
# [5.19.0](v5.18.6...v5.19.0) (2025-03-07)

### Features

* **ContainerAuthenticator:** add support for code engine workload ([#244](#244)) ([80518d2](80518d2))
@ibm-devx-sdk
Copy link
Copy Markdown

🎉 This PR is included in version 5.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants