dotnet 6.0.100#92991
Conversation
177025d to
3ff643f
Compare
carlocab
left a comment
There was a problem hiding this comment.
I think we should be able to remove this line:
homebrew-core/Formula/dotnet.rb
Line 24 in a241488
3ff643f to
6d516fb
Compare
6d516fb to
5505d16
Compare
5505d16 to
5756824
Compare
5756824 to
22d6d2d
Compare
|
Thanks for digging into this, @cho-m! As per dotnet/source-build#2756, I've changed the tag and revision to v6.0.102-source-build. Let's see how that goes! 😃 |
I've tried it locally and it still hit the same issue. I'm now trying a local build by backtracking to Note that CI is going to be blocked until queue frees up since we only allow 2 |
22d6d2d to
ffc5866
Compare
|
Local Intel build finally succeeded, though I don't see any linkage to Previously, it took over 6 hours for Linux build of .NET 5, so can only hope that it works as-is. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Didn't expect As expected, Locally, I had some trouble compiling Snippet of GitVersion build with diag logsEDIT: macOS dependent results are reasonable:
Now waiting on Linux... |
ffc5866 to
a4450aa
Compare
e699d02 to
bd8a56c
Compare
I think there is an additional |
|
|
|
Some things that need to be checked/done:
Things that can be done in separate PR or here:
|
|
Linux linkage you can see here: https://github.com/Homebrew/homebrew-core/runs/5225699996?check_suite_focus=true#step:9:12 |
@carlocab Fine with me as the items can be explored outside merge. I was mainly worried about /tmp space since I saw |
This should be fixed with high priority. This does not happen with Swift as |
I was worried about that. Probably need to clean out some of CI runners since there may be some leftover data. Would something like following work for moving into subdirectories: --- a/Formula/dotnet.rb
+++ b/Formula/dotnet.rb
@@ -71,10 +71,12 @@ class Dotnet < Formula
# TODO: Remove this in future release with .NET runtime v6.0.2+
(buildpath/"src/SourceBuild/tarball/patches/runtime").install resource("runtime-clang13-patch")
- sourcedir = buildpath.parent/"dotnet-sources"
- system "./build.sh", "/p:ArcadeBuildTarball=true",
- "/p:TarballDir=#{sourcedir}"
- cd sourcedir
+ (buildpath/"installer").install buildpath.children
+ cd "installer" do
+ system "./build.sh", "/p:ArcadeBuildTarball=true",
+ "/p:TarballDir=#{buildpath}/sources"
+ end
+ cd "sources"
# Disable package validation in source-build for reliability
# PR ref: https://github.com/dotnet/runtime/pull/60881
# TODO: Remove this in the next release |
|
Does the |
No, just somewhere outside the |
|
Ok, then I think #95302 should hopefully do the trick. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?