Skip to content

dotnet: ensure sources are cleaned up after install#95302

Merged
carlocab merged 2 commits into
Homebrew:masterfrom
carlocab:dotnet-sources
Feb 18, 2022
Merged

dotnet: ensure sources are cleaned up after install#95302
carlocab merged 2 commits into
Homebrew:masterfrom
carlocab:dotnet-sources

Conversation

@carlocab

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This leaves behind 50GB in build artefacts without this change.

This leaves behind 50GB in build artefacts without this change.
@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long build Set a long timeout for formula testing labels Feb 17, 2022
@carlocab carlocab requested review from Bo98 and cho-m February 17, 2022 12:38
@carlocab carlocab mentioned this pull request Feb 17, 2022
6 tasks
@cho-m

cho-m commented Feb 17, 2022

Copy link
Copy Markdown
Member

Will also need the self-hosted Linux as GitHub runners don't have enough disk space to build dotnet.

And probably want to recreate it before run since there may still be data from last build & we only have a 100G limit.

@carlocab carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Feb 17, 2022
Bo98
Bo98 previously approved these changes Feb 17, 2022
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 17, 2022
Comment thread Formula/dotnet.rb Outdated
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 17, 2022
@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 17, 2022
@carlocab carlocab merged commit bfe3cb0 into Homebrew:master Feb 18, 2022
@carlocab carlocab deleted the dotnet-sources branch February 18, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long build Set a long timeout for formula testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants