Skip to content

x86_64-elf-gdb, i386-elf-gdb: Fix ELF file support#78811

Closed
khirbat wants to merge 2 commits intoHomebrew:masterfrom
khirbat:gdb-10.2
Closed

x86_64-elf-gdb, i386-elf-gdb: Fix ELF file support#78811
khirbat wants to merge 2 commits intoHomebrew:masterfrom
khirbat:gdb-10.2

Conversation

@khirbat
Copy link
Copy Markdown
Contributor

@khirbat khirbat commented Jun 5, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

gdb is currently unable to load ELF files on Big Sur. See https://sourceware.org/bugzilla/show_bug.cgi?id=26949

$ echo 'void _start() {}' | x86_64-elf-gcc -g -xc -nostdlib -
$ /opt/homebrew/Cellar/x86_64-elf-gdb/10.1/bin/x86_64-elf-gdb -batch a.out
I'm sorry, Dave, I can't do that.  Symbol format `elf64-x86-64' unknown.

This PR

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jun 5, 2021
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 5, 2021 •
edited
Loading

Are these two patches the same? If so, can you add them to https://github.com/Homebrew/formula-patches and use the patch hosted there instead? You can probably add them to the gdb directory (and maybe create symlinks x86_64-elf-gdb and i386-elf-gdb that point to gdb).

How different is the patch you've embedded from the one in https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b413232211bf? Ah, is this what you get from patching acinclude.m4 and regenerating configure?

@khirbat
Copy link
Copy Markdown
Contributor Author

khirbat commented Jun 5, 2021

Yes, the two patches are the same. I will add the patch to formula-patches.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b413232211bf is from upstream master and does not apply cleanly to gdb 10.2. The embedded patch is the result of fixing the conflicts manually. I did not regenerate configure. I simply adapted the upstream diff to the gdb 10.2 tree.

@khirbat khirbat mentioned this pull request Jun 5, 2021
Merged
carlocab pushed a commit to Homebrew/formula-patches that referenced this pull request Jun 5, 2021
@khirbat
i386-elf-gdb, x86_64-elf-gdb: Add gdb 10.2 patch to fix ELF loading (#…
242630d 
…370)

See
https://sourceware.org/bugzilla/show_bug.cgi?id=26949
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b413232211bf
Homebrew/homebrew-core#78811
carlocab
carlocab reviewed Jun 5, 2021
View reviewed changes
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 5, 2021
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 5, 2021

Ah, you'll need to split that last commit into two, and preferably squash them with the respective original commits. That's why there's an automerge-skip label. BrewTestBot can't merge PRs that modify two formulae in a single commit.

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 5, 2021
carlocab
carlocab approved these changes Jun 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @khirbat.

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jun 6, 2021

🤖 A scheduled task has triggered a merge.

@khirbat khirbat deleted the gdb-10.2 branch June 6, 2021 01:38
@khirbat khirbat mentioned this pull request Jun 6, 2021
Merged
6 tasks
carlocab pushed a commit that referenced this pull request Jun 6, 2021
@khirbat
gdb: remove conflicts_with (#78818)
b363d46 
We no longer have any conflicting files.  See #78811
@carlocab carlocab mentioned this pull request Jun 20, 2021
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khirbat @carlocab @BrewTestBot