Closed
Conversation
See Homebrew#75458. This bottle is already relocatable, but that's from having implemented `RPATH` relocation. Using `#rpath` makes this more consistent with other formula and speeds up bottling/pouring (because it allows us to skip the relocation of `RPATH`s).
39 tasks
nandahkrishna
approved these changes
May 26, 2021
Contributor
|
🤖 A scheduled task has triggered a merge. |
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
May 26, 2021
See Homebrew#75458. The same comments as in Homebrew#78095 also apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?See #75458.
This bottle is already relocatable, but that's from having implemented
RPATHrelocation.Using
#rpathmakes this more consistent with other formula and speedsup bottling/pouring (because it allows us to skip the relocation of
RPATHs).