isl 0.24 by paperchalice · Pull Request #76444 · Homebrew/homebrew-core

paperchalice · 2021-05-02T04:12:44Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

paperchalice · 2021-05-02T12:53:27Z

flann official site http://www.cs.ubc.ca/research/flann is down.

carlocab · 2021-05-03T15:49:51Z

You should probably drop the libbi commit, as I'm not sure we want to rebuild that against the new Big Sur SDK yet. (It'll also need rebuilding once the Intel Big Sur runner has been updated to 11.3.)

The mpich issue will also be fixed by #73062, so you can just drop that commit and rebase once #73062 is merged.

carlocab · 2021-05-04T03:46:31Z

Please remove the perl revision bump for libbi.

Formula/isl.rb

carlocab · 2021-05-04T03:56:54Z

Formula/isl.rb

Why does it need llvm? Note that it still uses system clang to build even if you have an llvm build dependency.

It needs some clang libraries to build binding generator.

Let's build without those, we don't want to depend on llvm itself

carlocab · 2021-05-04T03:57:59Z

Formula/isl.rb

Did make install stop installing this? That's very weird.

Some C++ interface like cpp-checked.h are not installed by the make install, need to install them manually.

This need to be reported upstream, so it gets fixed by them and we can remove this ugliness in the next version.

carlocab · 2021-05-04T03:58:19Z

Formula/isl.rb

Why do we need to change the test?

Just test the C++ interface

carlocab · 2021-05-04T04:01:32Z

Formula/flann.rb

Would be good to try to keep the old test. We can use the new one you propose for now just to check that flann isn't broken by the isl version bump, though.

Currently resource URL are unreachable, ERROR 500.

Yes, saw your comment: #76444 (comment)

paperchalice · 2021-05-04T05:47:02Z

==> Testing libbi
/usr/bin/sandbox-exec -f /private/tmp/homebrew20210503-79670-2gsqxd.sb ruby -W1 -- /opt/homebrew/Library/Homebrew/test.rb /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/libbi.rb --verbose --retry
==> /opt/homebrew/Cellar/libbi/1.4.5_2/bin/libbi sample @test.conf
Stash.c: loadable library and perl binaries are mismatched (got handshake key 0xc800080, needed 0xc700080)
==> Testing libbi (again)
/usr/bin/sandbox-exec -f /private/tmp/homebrew20210503-79917-pm6fly.sb ruby -W1 -- /opt/homebrew/Library/Homebrew/test.rb /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/libbi.rb --verbose --retry
==> /opt/homebrew/Cellar/libbi/1.4.5_2/bin/libbi sample @test.conf
Stash.c: loadable library and perl binaries are mismatched (got handshake key 0xc800080, needed 0xc700080)
Error: libbi: failed

carlocab · 2021-05-04T06:04:22Z

That's expected. Homebrew/brew#11275

Also seen in a number of other PRs.

Formula/isl.rb

carlocab · 2021-05-10T01:05:45Z

You can also drop the flann commit; that should be fixed in its own PR.

carlocab · 2021-05-12T22:06:30Z

This should be good to merge when you drop the openmodelica commit and add a comment linking to an upstream report for the manual header installation.

Fixes CI failure seen in Homebrew#76444 and various other PRs. Also, update the license. There are no "or later" references in the source repository. See Homebrew/brew#11286.

Fixes CI failure seen in #76444 and various other PRs. Also, update the license. There are no "or later" references in the source repository. See Homebrew/brew#11286. Closes #77243. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

paperchalice · 2021-05-16T09:37:12Z

Reported to mailing list (isl and pet use the same mailing list) the only reply is

Sven Verdoolaege <sven.verdoolaege.isl@gmail.com>

I guess it's just that nobody ever requested them to be installed.
I don't use them myself.

skimo

carlocab · 2021-05-16T09:48:40Z

Reported to mailing list (isl and pet use the same mailing list) the only reply is
Sven Verdoolaege <sven.verdoolaege.isl@gmail.com>

I guess it's just that nobody ever requested them to be installed.
I don't use them myself.

skimo

This makes it sound like these headers aren't useful then. What are the extra headers used for?

paperchalice · 2021-05-16T09:50:23Z

These headers are contributed by llvm, the component polly use the C++ interface.

carlocab · 2021-05-16T09:59:24Z

It might help if you contributed a patch upstream to install these headers as well with make install.

carlocab

You should also drop the openmodelica commit, since 1.17.0 does not build.

carlocab · 2021-05-16T09:59:51Z

Formula/isl.rb

Suggested change

paperchalice · 2021-05-16T10:39:01Z

Drop the C++ headers now. In fact python binding doesn't need python@3.9, it is distributed by the source code, but is still not installed by make install. About the patch I don't think I can write it because I'm not familiar to automake.😰

openmodelica needs many upstream commits to build.

carlocab

Thanks @paperchalice.

BrewTestBot · 2021-05-16T20:14:49Z

@carlocab has triggered a merge.

paperchalice force-pushed the isl branch 3 times, most recently from e615062 to 6d48c1c Compare May 2, 2021 07:33

paperchalice force-pushed the isl branch 4 times, most recently from cbbca7b to c427753 Compare May 3, 2021 10:31

chenrui333 added the test failure CI fails while running the test-do block label May 3, 2021

paperchalice force-pushed the isl branch from c427753 to 9ea107a Compare May 4, 2021 02:32

paperchalice force-pushed the isl branch from 38e9122 to 8855672 Compare May 4, 2021 03:47

carlocab reviewed May 4, 2021

View reviewed changes

Formula/isl.rb Outdated Show resolved Hide resolved

paperchalice force-pushed the isl branch from 8855672 to 52fa311 Compare May 4, 2021 03:53

carlocab reviewed May 4, 2021

View reviewed changes

paperchalice force-pushed the isl branch 2 times, most recently from d9ec9e6 to 309fe0b Compare May 10, 2021 00:59

carlocab reviewed May 10, 2021

View reviewed changes

Formula/isl.rb Outdated Show resolved Hide resolved

paperchalice force-pushed the isl branch 2 times, most recently from a8a3c1d to 93d638f Compare May 12, 2021 08:05

carlocab mentioned this pull request May 14, 2021

libbi: revision bump (perl shebang fix) #77243

Closed

5 tasks

carlocab reviewed May 16, 2021

View reviewed changes

Formula/isl.rb Outdated

Copy link
Copy Markdown

Member

carlocab May 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

paperchalice force-pushed the isl branch from 93d638f to 24739a3 Compare May 16, 2021 10:29

paperchalice force-pushed the isl branch from 24739a3 to a166a67 Compare May 16, 2021 11:25

PaperChalice added 2 commits May 16, 2021 19:28

isl 0.24

ab902ab

pcl: specify glew explicitly

736c24c

paperchalice force-pushed the isl branch from a166a67 to 736c24c Compare May 16, 2021 11:29

carlocab approved these changes May 16, 2021

View reviewed changes

BrewTestBot closed this in 99f441b May 16, 2021

paperchalice deleted the isl branch June 8, 2021 08:25

github-actions bot added the outdated PR was locked due to age label Jul 9, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2021

Uh oh!

Conversation

paperchalice commented May 2, 2021

Uh oh!

paperchalice commented May 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlocab commented May 3, 2021

Uh oh!

carlocab commented May 4, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paperchalice commented May 4, 2021

Uh oh!

carlocab commented May 4, 2021

Uh oh!

Uh oh!

carlocab commented May 10, 2021

Uh oh!

carlocab commented May 12, 2021

Uh oh!

paperchalice commented May 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlocab commented May 16, 2021

Uh oh!

paperchalice commented May 16, 2021

Uh oh!

carlocab commented May 16, 2021

Uh oh!

carlocab left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paperchalice commented May 16, 2021

Uh oh!

carlocab left a comment

Choose a reason for hiding this comment

Uh oh!

BrewTestBot commented May 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paperchalice commented May 2, 2021 •

edited

Loading

paperchalice commented May 16, 2021 •

edited

Loading