Skip to content

cash-cli: switch to node@14#75705

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:cash-cli-node@14
Closed

cash-cli: switch to node@14#75705
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:cash-cli-node@14

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Apr 21, 2021

Same reasoning as in #75704.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the nodejs Node or npm use is a significant feature of the PR or issue label Apr 21, 2021
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 21, 2021

Didn't work:

==> /opt/homebrew/Cellar/cash-cli/4.2.1_1/bin/cash 100 USD PLN CHF
- Converting...
✖ Something went wrong :(

However, the same thing happens with the existing bottle:

==> /usr/local/Cellar/cash-cli/4.2.1/bin/cash 100 USD PLN CHF
- Converting...
✖ Something went wrong :(

@n-thumann n-thumann mentioned this pull request Apr 21, 2021
Merged
5 tasks
@carlocab carlocab mentioned this pull request Apr 21, 2021
Closed
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 21, 2021

Superseded by #75709.

@carlocab carlocab closed this Apr 21, 2021
@carlocab carlocab deleted the cash-cli-node@14 branch April 21, 2021 20:25
@carlocab carlocab added the superseded PR was replaced by another PR label Apr 21, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlocab @BrewTestBot