Closed
Conversation
This may be compatible with Node 16. However, it seems less wasteful of CI resources to switch this to Node 14 first and back to Node 16 later, rather than re-run Homebrew#75595 with a revision bump to `bcoin`.
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Apr 21, 2021
Same reasoning as in Homebrew#75704.
Closed
iMichka
approved these changes
Apr 21, 2021
Contributor
Contributor
|
🤖 A scheduled task has triggered a merge. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be compatible with Node 16. However, it seems less wasteful of
CI resources to switch this to Node 14 first and back to Node 16 later,
rather than re-run #75595 with a revision bump to
bcoin.brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?