Skip to content

sfml: make bottle relocatable#75449

Closed
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:sfml-relocatable
Closed

sfml: make bottle relocatable#75449
carlocab wants to merge 1 commit intoHomebrew:masterfrom
carlocab:sfml-relocatable

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Apr 18, 2021

Using opt_lib as the RPATH breaks relocatability.

See ebf0954 and e1847b6.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab carlocab mentioned this pull request Apr 18, 2021
Closed
5 tasks
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 18, 2021 

❯ jq '.[].bottle.cellar' <*.bottle.json
"any"
"any"
"any"
"any"

This was referenced Apr 19, 2021
Closed
Closed
SMillerDev
SMillerDev reviewed Apr 19, 2021
View reviewed changes
@carlocab
Copy link
Copy Markdown
Member Author

carlocab commented Apr 20, 2021

Needs the next brew release tag.

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed do not merge labels Apr 25, 2021
@carlocab
sfml: make bottle relocatable
739b125 
Using `opt_lib` as the RPATH breaks relocatability on macOS.

See ebf0954 and e1847b6.
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Apr 25, 2021
@carlocab
aom: make bottle relocatable
b58f317 
Setting RPATH to `lib` breaks relocatability on macOS.

See Homebrew#75450 and Homebrew#75449.
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Apr 26, 2021

🤖 A scheduled task has triggered a merge.

BrewTestBot pushed a commit that referenced this pull request Apr 26, 2021
@carlocab @BrewTestBot
aom: make bottle relocatable
b5f9737 
Setting RPATH to `lib` breaks relocatability on macOS.

See #75450 and #75449.

Closes #75457.

Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@carlocab carlocab deleted the sfml-relocatable branch May 16, 2021 19:12
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlocab @BrewTestBot @SMillerDev