Skip to content

global: really use Python 3 for build#73839

Closed
iMichka wants to merge 1 commit intoHomebrew:masterfrom
iMichka:global
Closed

global: really use Python 3 for build#73839
iMichka wants to merge 1 commit intoHomebrew:masterfrom
iMichka:global

Conversation

@iMichka
Copy link
Copy Markdown
Member

@iMichka iMichka commented Mar 24, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the linux to homebrew-core Migration of linuxbrew-core to homebrew-core label Mar 24, 2021
@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added python Python use is a significant feature of the PR or issue labels Mar 24, 2021
@mitchblank
Copy link
Copy Markdown
Contributor

The build failure issues are known from previous attempts to upgrade this formula to 6.6.5 (#61097 #64909) ..

The realpath issue may be fixed upstream ( http://cvs.savannah.gnu.org/viewvc/global/global/configure.ac?r1=1.204&r2=1.205&view=patch ) but I don't think anybody has tried to patch it in HB yet. So either we're waiting for someone to deal with that or for global to do another upstream release with the fix.

@iMichka
Copy link
Copy Markdown
Member Author

iMichka commented Apr 11, 2021

The actual configure error is (even with the patch):

configure:14276: checking whether POSIX.1-2008 realpath is equipped
configure:14293: clang -o conftest -g -O2   conftest.c  >&5
conftest.c:59:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
main(){ (void)realpath("/./tmp", (void *)0); return 0; }
^
conftest.c:59:15: error: implicit declaration of function 'realpath' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
main(){ (void)realpath("/./tmp", (void *)0); return 0; }
              ^
1 warning and 1 error generated.
configure:14293: $? = 1

@mitchblank
Copy link
Copy Markdown
Contributor

Are you sure? The match is to configure.ac, so you need to regenerate configure if you want the patch to take effect (or just make the equivalent patch to configure itself, of course)

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 11, 2021
@iMichka
Copy link
Copy Markdown
Member Author

iMichka commented Apr 11, 2021

Got it, forgot to reconfigure. I always forget to do that ... I got it to build locally, let's see what happens on CI

@iMichka iMichka force-pushed the global branch 3 times, most recently from fbab331 to 8abf40d Compare April 12, 2021 05:41
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 20, 2021
This was referenced Apr 22, 2021
@branchv branchv mentioned this pull request May 4, 2021
5 tasks
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 12, 2021
@github-actions github-actions bot closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linux to homebrew-core Migration of linuxbrew-core to homebrew-core missing license Formula has a missing license which should be added python Python use is a significant feature of the PR or issue stale No recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants