Skip to content

global 6.6.5#64909

Closed
Moisan wants to merge 1 commit intoHomebrew:masterfrom
Moisan:global_6.6.5
Closed

global 6.6.5#64909
Moisan wants to merge 1 commit intoHomebrew:masterfrom
Moisan:global_6.6.5

Conversation

@Moisan
Copy link
Copy Markdown
Member

@Moisan Moisan commented Nov 16, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Also migrate to python@3.9 based on #62319 .

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added python Python use is a significant feature of the PR or issue labels Nov 16, 2020
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Nov 16, 2020
@Moisan
Copy link
Copy Markdown
Member Author

Moisan commented Nov 16, 2020

So there is two issues still: pygments_parser.py doesn't point on the right python binary. Then when we try to fix it to use the correct one, it cannot find the pygments installation.

@Moisan
Copy link
Copy Markdown
Member Author

Moisan commented Nov 18, 2020

Closing for now.

@Moisan Moisan closed this Nov 18, 2020
@Moisan Moisan added the not merged PR was closed without being merged (and may need to be revisited) label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not merged PR was closed without being merged (and may need to be revisited) python Python use is a significant feature of the PR or issue python-3.9-migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants