Skip to content

aspell: explicitly depend on ncurses#48163

Merged
fxcoudert merged 1 commit intoHomebrew:masterfrom
idvorkin:master
Dec 22, 2019
Merged

aspell: explicitly depend on ncurses#48163
fxcoudert merged 1 commit intoHomebrew:masterfrom
idvorkin:master

Conversation

@idvorkin
Copy link
Contributor

@idvorkin idvorkin commented Dec 21, 2019

Required for linuxbrew, otherwise won't link to ncurses

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
    It works on linuxbrew, but on OSX it fails as follows - help on how to resolve would be awesome:
➜  Formula git:(master) brew audit --strict aspell                                                                            <<<
Traceback (most recent call last):
        2: from /Users/idvorkin/.gem/ruby/2.6.0/bin/bundle:23:in `<main>'
        1: from /usr/local/Cellar/ruby/2.6.3/lib/ruby/2.6.0/rubygems.rb:302:in `activate_bin_path'
/usr/local/Cellar/ruby/2.6.3/lib/ruby/2.6.0/rubygems.rb:283:in `find_spec_for_exe': Could not find 'bundler' (1.17.2) required by
your /usr/local/Homebrew/Library/Homebrew/Gemfile.lock. (Gem::GemNotFoundException)
To update to the latest version installed on your system, run `bundle update --bundler`.
To install the missing version, run `gem install bundler:1.17.2`
Error: failed to run `/Users/idvorkin/.gem/ruby/2.6.0/bin/bundle install`!

@Bo98
Copy link
Member

Bo98 commented Dec 21, 2019

You probably want uses_from_macos which is like depends_on but doesn't apply on macOS.

@idvorkin
Copy link
Contributor Author

idvorkin commented Dec 21, 2019 via email

@idvorkin
aspell: explicitly depend on ncurses
35d756e 
Required for linuxbrew, otherwise won't link to ncurses
@idvorkin
Copy link
Contributor Author

idvorkin commented Dec 21, 2019

Updated to use use_from_macos

@idvorkin idvorkin mentioned this pull request Dec 21, 2019
Closed
@iMichka
Copy link
Member

iMichka commented Dec 21, 2019

On the mac repo, we use use_from_macos. This is a no-op here. In theory the build bot would have told you so, but we did not have time/the manpower to write a test for this. So for now it's just a manual hint our maintainers need to tell you.

On mac we use the system ncurses (and most system libraries). On linux we need to depend on ncurses, as it is not provided by most systems.

@idvorkin
Copy link
Contributor Author

idvorkin commented Dec 21, 2019

Hymn, looks like the CI build didn't complete? Do I need to do something?

@iMichka
Copy link
Member

iMichka commented Dec 21, 2019

It's queued. We had some long builds lately, so there is some delay in the tests right now.

@idvorkin
Copy link
Contributor Author

idvorkin commented Dec 22, 2019

Wow CI builds really are slow :)

The error looks like a transient network connectivity issue (I can download the file now) is there a way to kick off a second run?

From: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/53907/version=catalina/testReport/junit/brew-test-bot/catalina/audit_aspell___online/

Error Message
failed: brew audit aspell --online
Stacktrace
        Error: 1 problem in 1 formula detected
aspell:
  * Stable resource "rw": The URL https://ftp.gnu.org/gnu/aspell/dict/rw/aspell-rw-0.50-0.tar.bz2 is not reachable

@fxcoudert fxcoudert merged commit 272dffa into Homebrew:master Dec 22, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@idvorkin @Bo98 @iMichka @fxcoudert