Skip to content

libdap: switch to openssl@3#134821

Merged
BrewTestBot merged 2 commits into
Homebrew:masterfrom
chenrui333:libdap-openssl3
Jul 11, 2023
Merged

libdap: switch to openssl@3#134821
BrewTestBot merged 2 commits into
Homebrew:masterfrom
chenrui333:libdap-openssl3

Conversation

@chenrui333

@chenrui333 chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 24, 2023
Closed
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 24, 2023
@chenrui333

chenrui333 commented Jun 24, 2023

Copy link
Copy Markdown
Member Author

configure: error: Cannot determine DODS XDR integer sizes

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Jun 24, 2023
@carlocab

carlocab commented Jun 24, 2023

Copy link
Copy Markdown
Member

Looks like https://bugs.gentoo.org/638494

@Bo98

Bo98 commented Jun 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Error is a little confusing but it makes more sense when you see the:

configure: WARNING: Cannot locate library containing xdr functions.

Needs a depends_on "libtirpc" on Linux.

@carlocab carlocab removed build failure CI fails while building the software linux Linux is specifically affected labels Jun 26, 2023
@carlocab

carlocab commented Jun 26, 2023

Copy link
Copy Markdown
Member 
  checking for xdr_void in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_uint32_t in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_u_int32_t in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_uint in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_u_int in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  configure: error: Cannot determine DODS XDR integer sizes

Seems to be mishandling the flags from pkg-config.

@carlocab carlocab added build failure CI fails while building the software linux Linux is specifically affected labels Jun 26, 2023
@Bo98

Bo98 commented Jun 26, 2023

Copy link
Copy Markdown
Member

OPENDAP/libdap4#228

@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:48
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
@carlocab carlocab mentioned this pull request Jul 1, 2023
Closed
13 tasks
@cho-m

cho-m commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Do we want to patch build scripts?

Could also temporarily override TIRPC_LIBS to allow current logic to work (since superenv should handle -L paths already and libtirpc is linked).

@carlocab carlocab force-pushed the libdap-openssl3 branch 2 times, most recently from a19e552 to 7fc6af1 Compare July 11, 2023 09:48
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software linux Linux is specifically affected labels Jul 11, 2023
@chenrui333 @carlocab
libdap: switch to openssl@3
72393fd 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 11, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 11, 2023 10:46
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 11, 2023
Merged via the queue into Homebrew:master with commit 5e22cf0 Jul 11, 2023
@chenrui333 chenrui333 deleted the libdap-openssl3 branch January 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chenrui333 @carlocab @Bo98 @cho-m @BrewTestBot @p-linnane