Skip to content

Fix handling of libtirpc pkg-config files with -L flags#228

Merged
jgallagher59701 merged 1 commit into
OPENDAP:masterfrom
Bo98:libtirpc-fix
Sep 26, 2023
Merged

Fix handling of libtirpc pkg-config files with -L flags#228
jgallagher59701 merged 1 commit into
OPENDAP:masterfrom
Bo98:libtirpc-fix

Conversation

@Bo98

@Bo98 Bo98 commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

When querying the libtirpc pkg-config, TIRPC_LIBS may return a value that includes a -L flag which messes up the sed that's performed here. It could technically return multiple -l flags as well.

Example of it breaking:

  checking for xdr_void in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_uint32_t in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_u_int32_t in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_uint in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no
  checking for xdr_u_int in -l-L/home/linuxbrew/.linuxbrew/Cellar/libtirpc/1.3.3/lib -ltirpc... no

Instead, we can simplify this by getting rid of the sed and skipping the AC_CHECK_LIB checks by simply hardwiring libtirpc to choose the integer functions that all supported libtirpc versions are known to have.

@Bo98 Bo98 mentioned this pull request Jun 26, 2023
Merged
@jgallagher59701

jgallagher59701 commented Sep 26, 2023

Copy link
Copy Markdown
Member

I'll run this so that it can access AWS.

@jgallagher59701 jgallagher59701 merged commit e5cdaa4 into OPENDAP:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bo98 @jgallagher59701