Skip to content

abricate: update deps and remove OpenSSL dependency#134408

Merged
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:abricate-openssl
Jul 1, 2023
Merged

abricate: update deps and remove OpenSSL dependency#134408
BrewTestBot merged 2 commits into
Homebrew:masterfrom
carlocab:abricate-openssl

Conversation

@carlocab

@carlocab carlocab commented Jun 21, 2023

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The comment says that it is used for Net::SSLeay, but this is no
longer a resource of this formula.

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Jun 21, 2023
@github-actions github-actions Bot added the perl Perl use is a significant feature of the PR or issue label Jun 21, 2023
@carlocab carlocab mentioned this pull request Jun 21, 2023
Closed
@chenrui333

chenrui333 commented Jun 22, 2023

Copy link
Copy Markdown
Member 
==> Downloading http://www.cpan.org/authors/id/R/RE/REHSACK/List-MoreUtils-XS-0.430.tar.gz
  Downloaded to: /github/home/.cache/Homebrew/downloads/93b91c522cb42b26103b41e6a7f845dd9ad3bc8e7c3419075c11d5336be16a1e--List-MoreUtils-XS-0.430.tar.gz
  SHA256: e8ce46d57c179eecd8758293e9400ff300aaf20fefe0a9d15b9fe2302b9cb242
  Resource: Exporter::Tiny
  Error: Failure while executing; `/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/4.0.24-13-ga626253\ \(Linux\;\ x86_64\ 5.15.0-1039-azure\)\ curl/7.81.0 --header Accept-Language:\ en --retry 3 --fail --location --silent --head --request GET [http://www.cpan.org/authors/id/T/TO/TOBYINK/Exporter-Tiny-1.004003.tar.gz`](http://www.cpan.org/authors/id/T/TO/TOBYINK/Exporter-Tiny-1.004003.tar.gz%60) exited with 22. Here's the output:

@chenrui333 chenrui333 removed the CI-no-bottles Merge without publishing bottles label Jun 24, 2023
@chenrui333 chenrui333 changed the title abricate: remove OpenSSL dependency abricate: update deps and remove OpenSSL dependency Jun 24, 2023
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jun 26, 2023
@carlocab
versioned_dependencies_conflicts_allowlist: update
582a6f5 
I've removed formulae that are no longer needed (see Homebrew#135023), and added
formulae that will either never support `openssl@3` or look likely to
take a lot more time to migrate.

See:

- abricate Homebrew#134408
- dafny Homebrew#134593
- mariadb@10.4 Homebrew#134675
- mysql@5.7 Homebrew#134421
- root Homebrew#134838
- sslyze Homebrew#134599
@carlocab carlocab mentioned this pull request Jun 26, 2023
Merged
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers openssl-3-migration Related to switching to an OpenSSL 3 dependency CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 1, 2023
@carlocab carlocab force-pushed the abricate-openssl branch from a2bb540 to f238840 Compare July 1, 2023 14:32
@carlocab carlocab mentioned this pull request Jul 1, 2023
Closed
13 tasks
@carlocab

carlocab commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Complaining about a missing Clone.pm on Linux, Big Sur (Intel and ARM), and Monterey (Intel only) at f2388405c523f0c786da177ac4976444036974e0. Kinda weird that it's working fine on ARM Monterey. CC @Bo98 in case you know what's going on.

@carlocab carlocab force-pushed the abricate-openssl branch from f238840 to 54e12dc Compare July 1, 2023 15:34
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers labels Jul 1, 2023
@carlocab

carlocab commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Kinda weird that it's working fine on ARM Monterey.

Ah, no, it wasn't working fine. This just doesn't have an ARM bottle so CI didn't fail. Mystery solved...

@carlocab carlocab force-pushed the abricate-openssl branch from 54e12dc to 6840d64 Compare July 1, 2023 15:52
@github-actions

github-actions Bot commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

❌ @carlocab bottle request for blast failed.

@carlocab
abricate: remove OpenSSL dependency
f33a352 
The comment says that it is used for `Net::SSLeay`, but this is no
longer a resource of this formula.

abricate: update deps

Signed-off-by: Rui Chen <rui@chenrui.dev>
@carlocab carlocab force-pushed the abricate-openssl branch from 6840d64 to f33a352 Compare July 1, 2023 16:30
@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2023
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2023
@carlocab carlocab closed this Jul 1, 2023
@carlocab carlocab reopened this Jul 1, 2023
@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2023
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 1, 2023
@carlocab carlocab requested a review from chenrui333 July 1, 2023 17:39
@github-actions

github-actions Bot commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 1, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 1, 2023 22:14
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 1, 2023
Merged via the queue into Homebrew:master with commit 63e89a0 Jul 1, 2023
@carlocab carlocab deleted the abricate-openssl branch July 2, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency perl Perl use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlocab @chenrui333 @nandahkrishna @BrewTestBot