glib, glib-utils: merge by carlocab · Pull Request #108307 · Homebrew/homebrew-core

carlocab · 2022-08-17T18:28:50Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

glib-utils currently leans heavily on the implementation details of Meson. We have no guarantees of stability of that API, so this can break with any Meson update, and we wouldn't even know that it happened until the next time glib-utils is rebuilt.

Let's get rid of it.

We can decouple glib from a specific versioned Python dependency by using uses_from_macos "python" instead. This does rely on our syntax check ignoring dependency conflicts of this type, but that's at least something we have control over (unlike Meson's internal API).

While we're here, let's switch this to using libffi from macOS.

The tap syntax check may fail from a number of formulae currently depending on glib-utils. To avoid having to rebuild them, I may remove those dependencies in a separate syntax-only PR.

Closes #107305.

cho-m · 2022-08-17T19:23:36Z

This does mean utilities won't work out-of-the-box on Mojave and older since they need Python 3, which could cascade into breaking dependent builds.

This is reason we originally didn't choose this approach as uses_from_macos "python", since: :catalina can trigger audit failure

This does mean utilities won't work out-of-the-box on Mojave and older since they need Python 3, which could cascade into breaking dependent builds.

Mojave support is "best-effort" --
I don't think supporting Mojave can justify the hacks in glib-utils.

This is reason we originally didn't choose this approach as uses_from_macos "python", since: :catalina can trigger audit failure

What audit failure was that?

The ones seen when mixing node (which uses alias for Python3) and emscripten (#95866)

Similarly seen with node + jupyterlab (#103972, #104097)

We should adjust the audit then.

If I had to guess, HOMEBREW_SIMULATE_MACOS_ON_LINUX is taking code paths of older version of macOS.

What do you think about making this the oldest supported release of macOS?

Off the top of my head, I think that would be fine. Looks like there wasn't really much discussion about it when it was added, so probably fine.

CC: @Bo98

The philosophy behind choosing the oldest macOS is that it includes the most dependencies (99.9% of the time). For auditing reasons this is usually a good thing.

We would have the same issue on Linux if the conflict audit wasn't disabled there. I would not rely on this remaining the case - I've been wanting to change that for a long time now.

The conflict audit failure here is really a special case. I'd say the way forward is to special case the python alias to not trigger the conflict audit, since those formulae are typically not bound to a particular version of Python. That's the real issue I feel.

I've merged Homebrew/brew#13714. Now we only need #108343.

Suggested change

uses_from_macos "python"

uses_from_macos "python", since: :catalina

Yep. This needs another run for the self-hosted runner and to rebuild some dependents against system libffi anyway.

Needed after Homebrew#108307.

carlocab · 2022-08-20T09:38:10Z

Opened Homebrew/brew#13725 so that we can do this without rebuilding all the formulae that do depends_on "glib-utils" => :build.

carlocab

glib will probably need a bunch of link_overwrites to prevent brew link conflicts for anyone who's installed glib-utils in the meantime.

While we're here, let's stop using Homebrew `libffi`. We don't need it.

This formula relies on some really terrible hacks. In particular, it depends on the implementation details of meson, and we have no guarantees about the stability of those details. Let's get rid of it.

carlocab · 2022-08-23T06:16:00Z

This ships a

_giscanner.cpython-310-darwin.so

so this is not flexible about the version of Python used.

carlocab · 2022-08-23T06:25:44Z

Dropping trezor-agent. Building it requires rebuilding harfbuzz without the glib-utils dependency. Will rebuild it separately when this is merged.

This cannot switch to `uses_from_macos "python"` since this ships C extension modules for Python, and these are tied to a specific Python version.

This has both versions of OpenSSL in its dep tree, but it does not link with anything that links with OpenSSL 1.1, so this conflict does not seem problematic.

cho-m · 2022-08-23T20:13:32Z

Linux CI didn't run properly with dependents not using the built glib.

Dependents tests: Error: 1583 failed steps!

And pygobject:

==> brew install --only-dependencies --verbose --build-bottle pygobject3
...
==> Downloading https://ghcr.io/v2/homebrew/core/glib/manifests/2.72.3_1
  /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/3.5.10\ \(Linux\;\ x86_64\ 5.15.0-1016-gcp\)\ curl/7.47.0 --header Accept-Language:\ en --fail --silent --retry 3 --header Accept:\ application/vnd.oci.image.index.v1\+json --header Authorization:\ Bearer\ QQ== --location --remote-time --output /github/home/.cache/Homebrew/downloads/762aec743625be859f12564877b8b8f08aedfa0ced86b6a5cf046f5da3204a9f--glib-2.72.3_1.bottle_manifest.json.incomplete https://ghcr.io/v2/homebrew/core/glib/manifests/2.72.3_1
  curl: (22) The requested URL returned error: 404 Not Found
  Error: pygobject3: Failed to download resource "glib_bottle_manifest"
  Download failed: https://ghcr.io/v2/homebrew/core/glib/manifests/2.72.3_1

carlocab · 2022-08-24T02:36:27Z

Seems unavoidable, unfortunately. At least, not without rebuilding all the glib-utils dependents. macOS looks fine, so there are unlikely to be too many issues here. Will merge this and fix any outstanding issues after.

BrewTestBot · 2022-08-24T02:37:06Z

@carlocab has triggered a merge.

BrewTestBot · 2022-08-24T02:37:24Z

@carlocab has triggered a merge.

BrewTestBot · 2022-08-24T02:37:34Z

⚠️ @carlocab bottle publish failed.

carlocab · 2022-08-24T02:58:34Z

pygobject3 rebottled on Linux at 54ac8d1.

trezor-agent rev bumped at #108756.

That should settle everything. If there's any remaining breakage, feel free to ping me.

BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 17, 2022

cho-m reviewed Aug 17, 2022

View reviewed changes

carlocab mentioned this pull request Aug 18, 2022

formula_auditor: create a versioned formula dependent conflict allowlist Homebrew/brew#13714

Merged

7 tasks

cho-m mentioned this pull request Aug 18, 2022

glib package's pkgconfig references binary not included #108344

Closed

2 tasks

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Aug 20, 2022

pango: remove glib-utils dependency.

7aeba7a

Needed after Homebrew#108307.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Aug 20, 2022

poppler-qt5: remove glib-utils dependency.

740c354

Needed after Homebrew#108307.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Aug 20, 2022

poppler: remove glib-utils dependency.

c5ab95a

Needed after Homebrew#108307.

This was referenced Aug 20, 2022

Remove glib-utils dependencies. #108497

Closed

formula_auditor: skip rename audit for glib-utils Homebrew/brew#13725

Merged

carlocab commented Aug 22, 2022

View reviewed changes

carlocab added 4 commits August 23, 2022 13:02

glib: restore python scripts

a6c8eb9

While we're here, let's stop using Homebrew `libffi`. We don't need it.

glib-utils: remove

1d0bbd0

This formula relies on some really terrible hacks. In particular, it depends on the implementation details of meson, and we have no guarantees about the stability of those details. Let's get rid of it.

formula_renames: merge glib-utils into glib

4bc29f4

gjs: revision bump for macOS libffi

dba8571

carlocab commented Aug 23, 2022

View reviewed changes

carlocab added 5 commits August 23, 2022 15:16

gobject-introspection: revision bump for macOS libffi

a03f17d

This cannot switch to `uses_from_macos "python"` since this ships C extension modules for Python, and these are tied to a specific Python version.

lanraragi: revision bump for macOS libffi

b3465cc

openmodelica: revision bump for macOS libffi

2f36990

pygobject3: revision bump for macOS libffi

a77f207

versioned_dependencies_conflicts_allowlist: add synergy-core

90f9b3e

This has both versions of OpenSSL in its dep tree, but it does not link with anything that links with OpenSSL 1.1, so this conflict does not seem problematic.

This was referenced Aug 24, 2022

Revert "formula_auditor: skip rename audit for glib-utils" Homebrew/brew#13748

Merged

trezor-agent: revision bump for macOS libffi #108756

Closed

carlocab mentioned this pull request Aug 25, 2022

fdroidserver: use libffi from macos #107652

Closed

paxswill mentioned this pull request Aug 25, 2022

glib formula now installs .gitignore file in bash completions directory #108936

Closed

2 tasks

kleisauke mentioned this pull request Sep 3, 2022

CI: remove redundant glib-utils dependency libvips/libvips#3022

Merged

carlocab mentioned this pull request Sep 18, 2022

synced_versions_formulae: remove glib-utils. #111032

Merged

	uses_from_macos "python"
	uses_from_macos "python", since: :catalina

Uh oh!

Conversation

carlocab commented Aug 17, 2022

Uh oh!

cho-m Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlocab Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

cho-m Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlocab Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

cho-m Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Rylan12 Aug 18, 2022

Choose a reason for hiding this comment

Uh oh!

Bo98 Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlocab Aug 20, 2022

Choose a reason for hiding this comment

Uh oh!

cho-m Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

carlocab Aug 23, 2022

Choose a reason for hiding this comment

Uh oh!

carlocab commented Aug 20, 2022

Uh oh!

carlocab left a comment

Choose a reason for hiding this comment

Uh oh!

carlocab Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlocab commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cho-m commented Aug 23, 2022

Uh oh!

carlocab commented Aug 24, 2022

Uh oh!

BrewTestBot commented Aug 24, 2022

Uh oh!

BrewTestBot commented Aug 24, 2022

Uh oh!

BrewTestBot commented Aug 24, 2022

Uh oh!

carlocab commented Aug 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cho-m Aug 17, 2022 •

edited

Loading

cho-m Aug 17, 2022 •

edited

Loading

Bo98 Aug 18, 2022 •

edited

Loading

carlocab Aug 23, 2022 •

edited

Loading

carlocab commented Aug 23, 2022 •

edited

Loading