Skip to content

Add fish shell completions to brew#6217

Merged
MikeMcQuaid merged 6 commits intoHomebrew:masterfrom
lwolfsonkin:brew-fish-completions
Jun 12, 2019
Merged

Add fish shell completions to brew#6217
MikeMcQuaid merged 6 commits intoHomebrew:masterfrom
lwolfsonkin:brew-fish-completions

Conversation

@lwolfsonkin
Copy link
Copy Markdown
Contributor

@lwolfsonkin lwolfsonkin commented Jun 9, 2019 •
edited
Loading

Closes #6172

  • Copy fish completions from github.com/laughedelic/brew-completions
  • Update completions readme to include fish
  • Rename fish functions to be more styled like most fish functions
  • Make completions for brew pin suggest only unpinned formulae
  • Added TODO for dropping brew search's cache desc_cache.json
  • Drop completions for nonexistent brew cask cleanup
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid requested changes Jun 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Copy fish completions from github.com/laughdelic/brew-completions

This URL doesn't work; can you confirm the source and if the license permits this?

Otherwise: looks good 👍

@erikgaal
Copy link
Copy Markdown

erikgaal commented Jun 11, 2019

The correct URL should be https://github.com/laughedelic/brew-completions/.

The license is GPLv3 so I don't think we can just merge this.

@reitermarkus
Copy link
Copy Markdown
Member

reitermarkus commented Jun 11, 2019

laughedelic/brew-completions#9

@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Jun 11, 2019

@laughedelic can you confirm you are happy for your code to be included in this repository under these terms: https://github.com/Homebrew/brew/blob/master/LICENSE.txt?

@lwolfsonkin lwolfsonkin mentioned this pull request Jun 11, 2019
Closed
@lwolfsonkin
Copy link
Copy Markdown
Contributor Author

lwolfsonkin commented Jun 11, 2019

@MikeMcQuaid: I corrected the URL in the PR description now. :)

@laughedelic
Copy link
Copy Markdown
Contributor

laughedelic commented Jun 12, 2019 •
edited
Loading

Thank you @lwolfsonkin for pushing this forward and taking extra effort for the improvements! 👏

I'm fine with the BSD license, but I would appreciate being mentioned as a co-author in the merge commit if this is fine with you:

Co-authored-by: Alexey Alekhin <laughedelic@gmail.com>

@MikeMcQuaid MikeMcQuaid merged commit ae025d6 into Homebrew:master Jun 12, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Jun 12, 2019

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lwolfsonkin!

I'm fine with the BSD license, but I would appreciate being mentioned as a co-author in the merge commit if this is fine with you:

Done, thanks for your initial work on this too @laughedelic: you also rock!

@lwolfsonkin lwolfsonkin mentioned this pull request Jun 12, 2019
Closed
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid requested changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can fish shell completions live in this repo?

5 participants

@lwolfsonkin @erikgaal @reitermarkus @MikeMcQuaid @laughedelic