A detailed description of the proposed feature
Currently, the fish shell completions for Homebrew exist primarily in two locations (of which I'm aware): the main fish shell repo and an extensive external repo. I would propose combining these two into fish shell completions that would live here alongside the bash and zsh completions in the completions directory.
The motivation for the feature
The completions existing bundled with the fish shell itself (which doesn't ship updates so often) can cause the completions to go out of date, especially when there are breaking API changes (like the brew cask search removal) that the completions would need to (relatively) swiftly deal with. Having the completions exist with Homebrew itself (which is nearly always up to date) would certainly alleviate this.
How the feature would be relevant to at least 90% of Homebrew users
Having functional and up to date completions for all the most popular shells is certainly of benefit to most Homebrew users.
What alternatives to the feature have been considered
Leaving the completions in their aformentioned locations.
Additionally
I would be totally willing to author this PR, and I would be interested in the feedback of @MindTooth and @laughedelic who primarily authored the aforementioned completions.
A detailed description of the proposed feature
Currently, the fish shell completions for Homebrew exist primarily in two locations (of which I'm aware): the main fish shell repo and an extensive external repo. I would propose combining these two into fish shell completions that would live here alongside the bash and zsh completions in the completions directory.
The motivation for the feature
The completions existing bundled with the fish shell itself (which doesn't ship updates so often) can cause the completions to go out of date, especially when there are breaking API changes (like the
brew cask searchremoval) that the completions would need to (relatively) swiftly deal with. Having the completions exist with Homebrew itself (which is nearly always up to date) would certainly alleviate this.How the feature would be relevant to at least 90% of Homebrew users
Having functional and up to date completions for all the most popular shells is certainly of benefit to most Homebrew users.
What alternatives to the feature have been considered
Leaving the completions in their aformentioned locations.
Additionally
I would be totally willing to author this PR, and I would be interested in the feedback of @MindTooth and @laughedelic who primarily authored the aforementioned completions.