Deprecate tap pinning (and remove odisabled)#5925
Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom Apr 3, 2019
MikeMcQuaid:more-deprecations
Merged
Deprecate tap pinning (and remove odisabled)#5925MikeMcQuaid merged 2 commits intoHomebrew:masterfrom MikeMcQuaid:more-deprecations
odisabled)#5925MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:more-deprecations
Conversation
6 tasks
To a novice user, that wording may be confusing. When the user calls
Also, the "is shadowed by" message that is printed when the user does something with a tap formula that shadows a core formula … maybe it could mention that this behavior is going away? |
Member
Author
|
@slhck Good points, I've updated some of the messaging. |
Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.
6 tasks
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Apr 23, 2019
Tap pinning is deprecated (Homebrew/brew#5925) in favor of using the fully qualified name. Closes #8027. PiperOrigin-RevId: 244838884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.
While we are handling deprecations: remove all
odisabled.This will not be merged until the next minor release is imminent.
brew stylewith your changes locally?brew testswith your changes locally?