Dockerfile: remove g++-12 from Ubuntu 24.04#21613
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Homebrew’s Ubuntu-based Docker image setup to align compiler tooling with Ubuntu 24.04 (“Noble”) by avoiding installation of the older g++-12 package there, while keeping it available for Ubuntu 22.04 (“Jammy”).
Changes:
- Install
skopeounconditionally in the main apt package set. - Restrict
g++-12installation to Ubuntu 22.x only (no longer installed on 24.x+).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Does upgrading GCC not work for Z3? |
The final goal of changes is to upgrade GCC as Z3 needs a newer libstdc++ so will be a runtime dependency. Specifically, Z3 needs support for We don't want to use brew |
@cho-m What's your suggested timescale? Note we'll land 5.1.0 any week now and 5.2.0 will be ~3 months after that (in case one of them is worth aiming for). |
Based on those dates, could target 5.2.0 for actual migration and add an advance notice in 5.1.0. Mainly since Ubuntu 26.04 release is April 23 and one idea we had in a prior discussion was to stay on 2nd latest LTS. Non-impacting changes like these can be merged now. Could also move some non-bottling CI to Ubuntu 24.04 to get a better idea if anything is broken. Impacting changes like glibc (Homebrew/homebrew-core#268900) will need to be timed closer to migration. |
@cho-m Sounds good. Could you try to land any "advance notice" code changes this week? If it's docs only: can you just dump here or in Slack what I should put in release notes? Thanks 🙇🏻 |
Will add a Optionally release notes could include "upcoming changes" section which mentions something like: we will update CI to Ubuntu 24.04 increasing minimum glibc to 2.39 and libstdc++ to 6.0.33. |
brew lgtm(style, typechecking and tests) with your changes locally?We will want to use
g++ == g++-13when moving to Noble so avoiding installingg++-12. Also move outskopeofrom conditional as we no longer need Ubuntu 20 or older.May start looking into moving to Ubuntu 24.04 earlier as we have our first impacted formula that has multiple dependents:
Mesa -> LLVM -> Z3)